[Merged by Bors] - chore: split Order.Interval.Set.Basic#23556
Closed
Parcly-Taxel wants to merge 2 commits intomasterfrom
Closed
[Merged by Bors] - chore: split Order.Interval.Set.Basic#23556Parcly-Taxel wants to merge 2 commits intomasterfrom
Order.Interval.Set.Basic#23556Parcly-Taxel wants to merge 2 commits intomasterfrom
Conversation
PR summary 9e33df94d4
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Order.Interval.Set.Basic | 219 | 217 | -2 (-0.91%) |
Import changes for all files
| Files | Import difference |
|---|---|
| There are 3953 files with changed transitive imports taking up over 172889 characters: this is too many to display! | |
You can run scripts/import_trans_difference.sh all locally to see the whole output. |
Declarations diff
No declarations were harmed in the making of this PR! 🐙
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
Decrease in tech debt: (relative, absolute) = (1.00, 0.09)
| Current number | Change | Type |
|---|---|---|
| 11 | -1 | large files |
Current commit 9e33df94d4
Reference commit c1fb70c492
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
Vierkantor
approved these changes
Apr 2, 2025
Contributor
Vierkantor
left a comment
There was a problem hiding this comment.
Having spent some time staring at this file in previous weeks, I agree that there is no other natural way to split it and keep the imports reasonable. And all the declarations survived intact. So: looks good to me. Thanks!
bors r+
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 2, 2025
Declarations requiring `LinearOrder` have been moved to `Order.Interval.Set.LinearOrder`.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
Order.Interval.Set.BasicOrder.Interval.Set.Basic
5 tasks
tannerduve
pushed a commit
that referenced
this pull request
May 13, 2025
Declarations requiring `LinearOrder` have been moved to `Order.Interval.Set.LinearOrder`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Declarations requiring
LinearOrderhave been moved toOrder.Interval.Set.LinearOrder.