[Merged by Bors] - fix(Tactic/Lift): replace simp at h h with simp at h#23437
Closed
vasnesterov wants to merge 4 commits intomasterfrom
Closed
[Merged by Bors] - fix(Tactic/Lift): replace simp at h h with simp at h#23437vasnesterov wants to merge 4 commits intomasterfrom
simp at h h with simp at h#23437vasnesterov wants to merge 4 commits intomasterfrom
Conversation
PR summary 7e1a618c81Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
vasnesterov
commented
Mar 29, 2025
Contributor
|
bors d+ |
Contributor
|
✌️ vasnesterov can now approve this pull request. To approve and merge a pull request, simply reply with |
Collaborator
Author
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 31, 2025
The `lift` tactic previously called `simp only [h_eq] at h h` instead of `simp only [h_eq] at h` when rewriting a local hypothesis `h` with `h_eq : old_value = ↑lifted_value`. This caused hypothesis duplication in some cases: [#mathlib4 > Bug in `lift` tactic? @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Bug.20in.20.60lift.60.20tactic.3F/near/508521400) This PR removes the second `h` in the `simp` call.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
simp at h h with simp at hsimp at h h with simp at h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
lifttactic previously calledsimp only [h_eq] at h hinstead ofsimp only [h_eq] at hwhen rewriting a local hypothesishwithh_eq : old_value = ↑lifted_value. This caused hypothesis duplication in some cases:#mathlib4 > Bug in `lift` tactic? @ 💬
This PR removes the second
hin thesimpcall.