[Merged by Bors] - fix(Tactic/Use): do not allow unprotected cdot#23257
Closed
eric-wieser wants to merge 3 commits intomasterfrom
Closed
[Merged by Bors] - fix(Tactic/Use): do not allow unprotected cdot#23257eric-wieser wants to merge 3 commits intomasterfrom
eric-wieser wants to merge 3 commits intomasterfrom
Conversation
PR summary d46f5b2933Import changes exceeding 2%
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Tactic.Use | 23 | 25 | +2 (+8.70%) |
| Mathlib.Tactic.CongrM | 83 | 85 | +2 (+2.41%) |
Import changes for all files
| Files | Import difference |
|---|---|
| There are 5680 files with changed transitive imports taking up over 241646 characters: this is too many to display! | |
You can run scripts/import_trans_difference.sh all locally to see the whole output. |
Declarations diff
+ elabWithoutCDot
+ withoutCDot
+ withoutCDotImpl
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
7f4ea30 to
53afdd8
Compare
53afdd8 to
9ccc8be
Compare
Member
|
LGTM bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 26, 2025
Zulip thread: [#mathlib4 > `use ·` @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/.60use.20.C2.B7.60/near/448279748)
Contributor
|
Build failed (retrying...): |
Member
|
bors r- Please merge master |
Contributor
|
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
|
Canceled. |
|
As this PR is labelled bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 26, 2025
Zulip thread: [#mathlib4 > `use ·` @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/.60use.20.C2.B7.60/near/448279748) Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
Paul-Lez
pushed a commit
that referenced
this pull request
Mar 27, 2025
Zulip thread: [#mathlib4 > `use ·` @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/.60use.20.C2.B7.60/near/448279748) Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zulip thread: #mathlib4 > `use ·` @ 💬