Skip to content

[Merged by Bors] - chore(RingTheory/TwoSidedIdeal/Operations): add some lemmas#23216

Closed
Whysoserioushah wants to merge 10 commits intomasterfrom
more_on_ideal
Closed

[Merged by Bors] - chore(RingTheory/TwoSidedIdeal/Operations): add some lemmas#23216
Whysoserioushah wants to merge 10 commits intomasterfrom
more_on_ideal

Conversation

@Whysoserioushah
Copy link
Copy Markdown
Collaborator

@Whysoserioushah Whysoserioushah commented Mar 22, 2025 •
edited by eric-wieser
Loading

Co-authored-by: @jjaassoonn

Open in Gitpod

@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Mar 22, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 22, 2025 •
edited
Loading

PR summary 41b421174f

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ coe_bot
+ coe_top
+ span_le

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Mar 22, 2025
eric-wieser
eric-wieser reviewed Mar 22, 2025
View reviewed changes
eric-wieser
eric-wieser reviewed Mar 22, 2025
View reviewed changes
eric-wieser
eric-wieser reviewed Mar 22, 2025
View reviewed changes
eric-wieser
eric-wieser reviewed Mar 23, 2025
View reviewed changes
eric-wieser
eric-wieser reviewed Mar 24, 2025
View reviewed changes
@github-actions github-actions bot removed the large-import Automatically added label for PRs with a significant increase in transitive imports label Mar 24, 2025
eric-wieser
eric-wieser reviewed Mar 25, 2025
View reviewed changes
eric-wieser
eric-wieser reviewed Mar 25, 2025
View reviewed changes
@eric-wieser eric-wieser added the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Mar 25, 2025
@eric-wieser
Copy link
Copy Markdown
Member

eric-wieser commented Mar 25, 2025

bors d+

Thanks!

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 25, 2025

✌️ Whysoserioushah can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Mar 25, 2025
@eric-wieser eric-wieser changed the title chore(Mathlib/RingTheory/TwoSidedIdeal/Operations): add some lemmas chore(RingTheory/TwoSidedIdeal/Operations): add some lemmas Mar 25, 2025
@Whysoserioushah
Copy link
Copy Markdown
Collaborator Author

Whysoserioushah commented Mar 25, 2025

bors d+

Thanks!

thanks!

@Whysoserioushah
Copy link
Copy Markdown
Collaborator Author

Whysoserioushah commented Mar 25, 2025

bors r+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 25, 2025

👎 Rejected by label

@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Mar 25, 2025
@eric-wieser
Copy link
Copy Markdown
Member

eric-wieser commented Mar 25, 2025

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Mar 25, 2025
mathlib-bors bot pushed a commit that referenced this pull request Mar 25, 2025
@Whysoserioushah
chore(RingTheory/TwoSidedIdeal/Operations): add some lemmas (#23216)
260f800 
Co-authored-by: @jjaassoonn
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 25, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(RingTheory/TwoSidedIdeal/Operations): add some lemmas [Merged by Bors] - chore(RingTheory/TwoSidedIdeal/Operations): add some lemmas Mar 25, 2025
@mathlib-bors mathlib-bors bot closed this Mar 25, 2025
@mathlib-bors mathlib-bors bot deleted the more_on_ideal branch March 25, 2025 10:42
@Whysoserioushah Whysoserioushah mentioned this pull request Mar 25, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@erdOne erdOne Awaiting requested review from erdOne

@kbuzzard kbuzzard Awaiting requested review from kbuzzard

Assignees

No one assigned

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Whysoserioushah @eric-wieser