[Merged by Bors] - perf: speed up Finset.toLeft and Finset.toRight#23079
Closed
eric-wieser wants to merge 4 commits intomasterfrom
Closed
[Merged by Bors] - perf: speed up Finset.toLeft and Finset.toRight#23079eric-wieser wants to merge 4 commits intomasterfrom
Finset.toLeft and Finset.toRight#23079eric-wieser wants to merge 4 commits intomasterfrom
Conversation
This is about 10% faster, but also avoids stackoverflows: ``` \#eval ((Finset.Icc 0 100000).map (.inl (β := ℕ))).toLeft.card ``` would previously fail.
PR summary 1d68d2735c
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Data.Finset.Sum | 466 | 427 | -39 (-8.37%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.Data.Finset.Sum |
-39 |
Mathlib.Data.Finite.Sum Mathlib.Data.Fintype.Sum |
-38 |
Declarations diff
No declarations were harmed in the making of this PR! 🐙
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
Contributor
|
Ha, this is clearly the better definition - Yaël and I were saying how we'd both prefer it if Finset.filterMap existed for this; turns out it does! |
b-mehta
reviewed
Mar 19, 2025
| def toLeft (s : Finset (α ⊕ β)) : Finset α := | ||
| s.disjiUnion (Sum.elim singleton (fun _ => ∅)) <| by | ||
| simp [Set.PairwiseDisjoint, Set.Pairwise, Function.onFun, eq_comm] | ||
| s.filterMap (Sum.elim some fun _ => none) (by clear x; aesop) |
Contributor
There was a problem hiding this comment.
Is there a tracking issue for aesop pulling in x here?
If aesop changes (fixes) its behaviour, this might error, right?
Member
Author
There was a problem hiding this comment.
A fix to aesop would make this clear unnecessary, but it wouldn't make it an error
Member
Author
There was a problem hiding this comment.
Contributor
|
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
|
As this PR is labelled bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 19, 2025
This is about 10% faster than master, but also avoids stackoverflows: ```lean #eval ((Finset.Icc 0 100000).map (.inl (β := ℕ))).toLeft.card ``` would previously fail. `aesop` is somehow capturing an unused local variable here, but `clear` sets it straight. As a bonus, this reduces the imports needed for this file.
Contributor
|
Build failed: |
|
As this PR is labelled bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 19, 2025
This is about 10% faster than master, but also avoids stackoverflows: ```lean #eval ((Finset.Icc 0 100000).map (.inl (β := ℕ))).toLeft.card ``` would previously fail. `aesop` is somehow capturing an unused local variable here, but `clear` sets it straight. As a bonus, this reduces the imports needed for this file.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
Finset.toLeft and Finset.toRightFinset.toLeft and Finset.toRight
tukamilano
pushed a commit
that referenced
this pull request
Mar 20, 2025
This is about 10% faster than master, but also avoids stackoverflows: ```lean #eval ((Finset.Icc 0 100000).map (.inl (β := ℕ))).toLeft.card ``` would previously fail. `aesop` is somehow capturing an unused local variable here, but `clear` sets it straight. As a bonus, this reduces the imports needed for this file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is about 10% faster than master, but also avoids stackoverflows:
would previously fail.
aesopis somehow capturing an unused local variable here, butclearsets it straight.As a bonus, this reduces the imports needed for this file.
This is a more minimal version of #23020 that is also twice as fast.