Skip to content

feat: define immersions and smooth embeddings in infinite dimensions#23040

Open
grunweg wants to merge 75 commits intomasterfrom
MR-define-immersions
Open

feat: define immersions and smooth embeddings in infinite dimensions#23040
grunweg wants to merge 75 commits intomasterfrom
MR-define-immersions

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Mar 18, 2025

Sadly, we cannot prove most nice things about them yet, as we don't have
the inverse function theorem yet.

TODO: prove the few things we can already say


Open in Gitpod

grunweg added 2 commits March 17, 2025 22:41
Sadly, we cannot prove most nice things about them yet, as we don't have
the inverse function theorem yet.
@grunweg grunweg added WIP Work in progress t-differential-geometry Manifolds etc labels Mar 18, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 18, 2025

PR summary 93f7c1d0aa

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Analysis.NormedSpace.HahnBanach.Splits (new file) 1855
Mathlib.Geometry.Manifold.MSplits (new file) 1949
Mathlib.Geometry.Manifold.IsImmersionEmbedding (new file) 1950

Declarations diff

+ ContinuousLinearMap.Splits
+ IsImmersion
+ IsImmersionAt
+ IsLocalDiffeomorphAt.mfderiv_toContinuousLinearEquiv
+ IsSmoothEmbedding
+ LeftInverse.of_composition
+ MSplits
+ MSplitsAt
+ RightInverse.of_composition
+ Submodule.ClosedComplemented.prod
+ Submodule.sum_assoc
+ _root_.ContinuousLinearEquiv.splits
+ _root_.Diffeomorph.splits
+ _root_.IsLocalDiffeomorph.splits
+ _root_.IsLocalDiffeomorphAt.msplitsAt
+ _root_.Submodule.map_add
+ _root_.isImmersionAt_iff_msplitsAt
+ antilipschitzConstant
+ antilipschitzWith
+ antilipschitz_aux
+ closedComplemented
+ codChart
+ codChart_mem_maximalAtlas
+ compCLE_left
+ compCLE_right
+ comp_diffeomorph_left_iff
+ comp_diffeomorph_right_iff
+ comp_isLocalDiffeomorphAt_left
+ comp_isLocalDiffeomorphAt_left_iff
+ comp_isLocalDiffeomorphAt_right
+ comp_isLocalDiffeomorphAt_right_iff
+ comp_isLocalDiffeomorph_left
+ comp_isLocalDiffeomorph_right
+ complement
+ complement_isClosed
+ complement_isCompl
+ congr_of_eventuallyEq
+ contMDiffAt
+ continuousWithinAt
+ disjoint_aux
+ domChart
+ domChart_mem_maximalAtlas
+ equiv
+ extend
+ extend_mfderiv_toContinousLinearEquiv
+ extend_mfderiv_toContinousLinearEquiv_coe
+ extend_symm
+ extend_symm_mfderiv_toContinousLinearEquiv
+ extend_symm_mfderiv_toContinousLinearEquiv_coe
+ injective
+ isClosedMap
+ isClosed_range
+ isEmbedding
+ isImmersion
+ isImmersionAt
+ mdifferentiableAt
+ mdifferentiableAt_of_mfderiv_injective
+ mem_codChart_source
+ mem_domChart_source
+ mfderiv_toContinuousLinearEquiv_coe
+ msplitsAt
+ of_finiteDimensional_of_mfderiv_injective
+ of_injective_of_finiteDimensional'
+ of_injective_of_finiteDimensional_of_completeSpace
+ of_mfderiv_injective
+ of_mfderiv_injective_of_compactSpace_of_T2Space
+ range_prodMap
+ writtenInCharts
++ contMDiff
++ continuousAt
++ foo
++ of_injective_of_finiteDimensional
+++ mfderiv_injective
++++ congr
+++++ prodMap
++++++ comp

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Increase in tech debt: (relative, absolute) = (2.00, 0.00)
Current number Change Type
922 2 erw

Current commit 93f7c1d0aa
Reference commit ddb4ebecc0

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

grunweg added 9 commits March 18, 2025 15:50
I'd merely like to ask for equality on the source of the inverse extChart
In finite dimensions, that certainly holds; need to think about inf-dim
The naive proof certainly fails (we get a coordinate change between the
two charts in the middle, which can be anything, and need not be linear at
all). Can we always "modify" a slice chart to match a modification downstairs?
I presume no, but would need to think...
@leanprover-community-bot-assistant
Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 8, 2025
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Jun 19, 2025
@grunweg grunweg mentioned this pull request Jun 25, 2025
2 tasks
grunweg added a commit to grunweg/mathlib4 that referenced this pull request Aug 16, 2025
I wanted this lemma both while working on an early version of leanprover-community#28056
and while working on leanprover-community#23040: time to add it.
Besides, it fills a natural API gap.
grunweg added a commit to grunweg/mathlib4 that referenced this pull request Aug 16, 2025
I wanted this lemma both while working on an early version of leanprover-community#28056
and while working on leanprover-community#23040: time to add it.
Besides, it fills a natural API gap.
grunweg added a commit to grunweg/mathlib4 that referenced this pull request Oct 1, 2025
I wanted this lemma both while working on an early version of leanprover-community#28056
and while working on leanprover-community#23040: time to add it.
Besides, it fills a natural API gap.
mathlib-bors bot pushed a commit that referenced this pull request Oct 2, 2025
I wanted this lemma both while working on an early version of #28056 and while working on #23040: time to add it.
Besides, it fills a natural API gap.
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Oct 2, 2025

Status: #28793 and friends add the basic definitions (and basic API) - let's land those first and then revisit this PR (for the "composition of immersions") part.

@grunweg grunweg added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Oct 2, 2025
joelriou pushed a commit to joelriou/mathlib4 that referenced this pull request Oct 2, 2025
I wanted this lemma both while working on an early version of leanprover-community#28056 and while working on leanprover-community#23040: time to add it.
Besides, it fills a natural API gap.
mitchell-horner pushed a commit to mitchell-horner/mathlib4 that referenced this pull request Oct 6, 2025
I wanted this lemma both while working on an early version of leanprover-community#28056 and while working on leanprover-community#23040: time to add it.
Besides, it fills a natural API gap.
BeibeiX0 pushed a commit to BeibeiX0/mathlib4 that referenced this pull request Nov 7, 2025
I wanted this lemma both while working on an early version of leanprover-community#28056 and while working on leanprover-community#23040: time to add it.
Besides, it fills a natural API gap.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) t-differential-geometry Manifolds etc WIP Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants