Skip to content

[Merged by Bors] - chore(Topology/Irreducible): fix the module docstring#22793

Closed
urkud wants to merge 1 commit intomasterfrom
YK-irreducible-doc
Closed

[Merged by Bors] - chore(Topology/Irreducible): fix the module docstring#22793
urkud wants to merge 1 commit intomasterfrom
YK-irreducible-doc

Conversation

@urkud
Copy link
Copy Markdown
Member

@urkud urkud commented Mar 10, 2025

Was introduced in #7628.


Open in Gitpod

@urkud urkud requested a review from loefflerd March 10, 2025 15:43
@github-actions
Copy link
Copy Markdown

PR summary 9e032a12fc

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Mar 10, 2025
@loefflerd
Copy link
Copy Markdown
Contributor

Sorry, looks like this one was my fault, thanks for fixing it!

maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by loefflerd.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Mar 10, 2025
@loefflerd loefflerd added documentation Improvements or additions to documentation easy < 20s of review time. See the lifecycle page for guidelines. maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Mar 10, 2025
@loefflerd
Copy link
Copy Markdown
Contributor

(not sure how the "maintainer-merge" label got unapplied, must be some kind of race condition with me manually adding the "documentation" label)

Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Mar 10, 2025
mathlib-bors bot pushed a commit that referenced this pull request Mar 10, 2025
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 10, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Topology/Irreducible): fix the module docstring [Merged by Bors] - chore(Topology/Irreducible): fix the module docstring Mar 10, 2025
@mathlib-bors mathlib-bors bot closed this Mar 10, 2025
@mathlib-bors mathlib-bors bot deleted the YK-irreducible-doc branch March 10, 2025 18:45
tukamilano pushed a commit that referenced this pull request Mar 20, 2025
idontgetoutmuch pushed a commit to idontgetoutmuch/mathlib4 that referenced this pull request Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants