Skip to content

[Merged by Bors] - chore: deprecations for nightly-2025-03-09#22778

Closed
kim-em wants to merge 5 commits intomasterfrom
renames_for_nightly-2025-03-09
Closed

[Merged by Bors] - chore: deprecations for nightly-2025-03-09#22778
kim-em wants to merge 5 commits intomasterfrom
renames_for_nightly-2025-03-09

Conversation

@kim-em
Copy link
Copy Markdown
Contributor

@kim-em kim-em commented Mar 10, 2025

This PR installs some deprecations to make room for changes in nightly-2025-03-09. This will be short-lived, but perhaps useful nevertheless.

@kim-em kim-em mentioned this pull request Mar 10, 2025
Merged
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 10, 2025 •
edited
Loading

PR summary 1398aebc87

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ ediv_emod_unique''
+ emod_lt_abs
+ natAbs_ediv_of_dvd
+ sign_eq_ediv_abs'

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

grunweg
grunweg reviewed Mar 10, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah: so this adds deprecations to account for renames that already happened on nightly? Fair enough, if this is useful to you, I don't mind merging it.
maintainer merge?

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 10, 2025

🚀 Pull request has been placed on the maintainer queue by grunweg.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Mar 10, 2025
@jcommelin
Copy link
Copy Markdown
Member

jcommelin commented Mar 10, 2025

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 10, 2025

✌️ kim-em can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Mar 10, 2025
@kim-em
Copy link
Copy Markdown
Contributor Author

kim-em commented Mar 10, 2025

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Mar 10, 2025
mathlib-bors bot pushed a commit that referenced this pull request Mar 10, 2025
@kim-em
chore: deprecations for nightly-2025-03-09 (#22778)
3f7ac34 
This PR installs some deprecations to make room for changes in nightly-2025-03-09. This will be short-lived, but perhaps useful nevertheless.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 11, 2025

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Mar 11, 2025
@kim-em
chore: deprecations for nightly-2025-03-09 (#22778)
1664143 
This PR installs some deprecations to make room for changes in nightly-2025-03-09. This will be short-lived, but perhaps useful nevertheless.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 11, 2025

Build failed (retrying...):

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 11, 2025

Canceled.

@kim-em
Copy link
Copy Markdown
Contributor Author

kim-em commented Mar 11, 2025

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Mar 11, 2025
@kim-em
chore: deprecations for nightly-2025-03-09 (#22778)
9231a9d 
This PR installs some deprecations to make room for changes in nightly-2025-03-09. This will be short-lived, but perhaps useful nevertheless.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 11, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: deprecations for nightly-2025-03-09 [Merged by Bors] - chore: deprecations for nightly-2025-03-09 Mar 11, 2025
@mathlib-bors mathlib-bors bot closed this Mar 11, 2025
@mathlib-bors mathlib-bors bot deleted the renames_for_nightly-2025-03-09 branch March 11, 2025 02:50
tukamilano pushed a commit that referenced this pull request Mar 20, 2025
@kim-em @tukamilano
chore: deprecations for nightly-2025-03-09 (#22778)
6e5f2f4 
This PR installs some deprecations to make room for changes in nightly-2025-03-09. This will be short-lived, but perhaps useful nevertheless.
idontgetoutmuch pushed a commit to idontgetoutmuch/mathlib4 that referenced this pull request Apr 7, 2025
@kim-em @idontgetoutmuch
chore: deprecations for nightly-2025-03-09 (leanprover-community#22778)
b5c8274 
This PR installs some deprecations to make room for changes in nightly-2025-03-09. This will be short-lived, but perhaps useful nevertheless.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grunweg grunweg grunweg left review comments

Assignees

No one assigned

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kim-em @jcommelin @grunweg