Skip to content

[Merged by Bors] - fix(CI): adapt to new olean path#22506

Closed
adomani wants to merge 4 commits intomasterfrom
adomani/update_olean_path
Closed

[Merged by Bors] - fix(CI): adapt to new olean path#22506
adomani wants to merge 4 commits intomasterfrom
adomani/update_olean_path

Conversation

@adomani
Copy link
Copy Markdown
Contributor

@adomani adomani commented Mar 3, 2025

The path where the oleans are stored appears to be contained inside an extra lean layer.

Reported on Zulip

As mentioned below, this is a consequence of lean4#7001.


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 3, 2025

PR summary c96844f7f1

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the CI Modifies the continuous integration setup or other automation label Mar 3, 2025
@adomani adomani marked this pull request as ready for review March 3, 2025 16:29
id: get
run: |
rm -rf .lake/build/lib/Mathlib/
rm -rf .lake/build/lib/lean/Mathlib .lake/build/lib/Mathlib/
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's split this into two commands, so we can leave a comment saying that one is for cleaning up pre-4.18.0-rc1 oleans.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Split!

@eric-wieser
Copy link
Copy Markdown
Member

@tydeu, do you happen to know the lean PR that made this change, to reference here?

@tydeu
Copy link
Copy Markdown
Collaborator

tydeu commented Mar 5, 2025

@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Mar 11, 2025

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 11, 2025

✌️ adomani can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Mar 11, 2025
@adomani
Copy link
Copy Markdown
Contributor Author

adomani commented Mar 12, 2025

Thanks! I'll merge this and see if the step printing the size of the oleans works again.

bors r+

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Mar 12, 2025
mathlib-bors bot pushed a commit that referenced this pull request Mar 12, 2025
The path where the oleans are stored appears to be contained inside an extra `lean` layer.

Reported on [Zulip](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Error.20in.20CI.20step.20.22print.20sizes.20of.20oleans.22)

As mentioned below, this is a consequence of [lean4#7001](leanprover/lean4#7001).
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 12, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title fix(CI): adapt to new olean path [Merged by Bors] - fix(CI): adapt to new olean path Mar 12, 2025
@mathlib-bors mathlib-bors bot closed this Mar 12, 2025
@mathlib-bors mathlib-bors bot deleted the adomani/update_olean_path branch March 12, 2025 17:13
tukamilano pushed a commit that referenced this pull request Mar 20, 2025
The path where the oleans are stored appears to be contained inside an extra `lean` layer.

Reported on [Zulip](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Error.20in.20CI.20step.20.22print.20sizes.20of.20oleans.22)

As mentioned below, this is a consequence of [lean4#7001](leanprover/lean4#7001).
idontgetoutmuch pushed a commit to idontgetoutmuch/mathlib4 that referenced this pull request Apr 7, 2025
The path where the oleans are stored appears to be contained inside an extra `lean` layer.

Reported on [Zulip](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Error.20in.20CI.20step.20.22print.20sizes.20of.20oleans.22)

As mentioned below, this is a consequence of [lean4#7001](leanprover/lean4#7001).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Modifies the continuous integration setup or other automation delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants