Skip to content

[Merged by Bors] - chore(Algebra/Order/Hom): initliaze simps for Order(Add)MonoidFoo#22402

Closed
pechersky wants to merge 2 commits intomasterfrom
pechersky/initialize-simps-order-monoid-iso
Closed

[Merged by Bors] - chore(Algebra/Order/Hom): initliaze simps for Order(Add)MonoidFoo#22402
pechersky wants to merge 2 commits intomasterfrom
pechersky/initialize-simps-order-monoid-iso

Conversation

@pechersky
Copy link
Copy Markdown
Contributor

@pechersky pechersky commented Feb 28, 2025

and define Order(Add)MonoidIso.symm
bringing along a copy of lemmas from MulEquiv

clean up the simps

Open in Gitpod

@pechersky
chore(Algebra/Order/Hom): initliaze simps for Order(Add)MonoidFoo
7b03e85 
and define `Order(Add)MonoidIso.symm`
bringing along a copy of lemmas from MulEquiv

clean up the simps
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 28, 2025 •
edited
Loading

PR summary 0c62ea9db3

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Simps.apply
+ Simps.symm_apply
+ apply_eq_iff_symm_apply
+ apply_symm_apply
+ coe_toEquiv_symm
+ comp_symm_eq
+ eq_comp_symm
+ eq_symm_apply
+ eq_symm_comp
+ equivLike_inv_eq_symm
+ invFun_eq_symm
+ refl_symm
+ self_comp_symm
+ symm
+ symm_apply_apply
+ symm_apply_eq
+ symm_bijective
+ symm_comp_eq
+ symm_comp_self
+ symm_symm
+ toEquiv_symm

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Feb 28, 2025
This was referenced Feb 28, 2025
Closed
Closed
@urkud
Copy link
Copy Markdown
Member

urkud commented Mar 17, 2025

Could you please run one of the scripts discussed in https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Lean-based.20.22changed.20names.22.20script.3F to see what simps-generated lemmas changed their names?

@pechersky
Copy link
Copy Markdown
Contributor Author

pechersky commented Mar 18, 2025

Only OrderMonoidIso.unitsWithZero_toFun changed to OrderMonoidIso.unitsWithZero_apply.

$ diff -y --suppress-common-lines 0c62ea9.out 5449dc90.out 
OrderAddMonoidIso.Simps.apply				      <
OrderAddMonoidIso.Simps.symm_apply			      <
OrderAddMonoidIso.apply_eq_iff_symm_apply		      <
OrderAddMonoidIso.apply_symm_apply			      <
OrderAddMonoidIso.coe_toEquiv_symm			      <
OrderAddMonoidIso.comp_symm_eq				      <
OrderAddMonoidIso.eq_comp_symm				      <
OrderAddMonoidIso.eq_symm_apply				      <
OrderAddMonoidIso.eq_symm_comp				      <
OrderAddMonoidIso.equivLike_neg_eq_symm			      <
OrderAddMonoidIso.invFun_eq_symm			      <
OrderAddMonoidIso.refl_symm				      <
OrderAddMonoidIso.self_comp_symm			      <
OrderAddMonoidIso.symm					      <
OrderAddMonoidIso.symm_apply_apply			      <
OrderAddMonoidIso.symm_apply_eq				      <
OrderAddMonoidIso.symm_bijective			      <
OrderAddMonoidIso.symm_comp_eq				      <
OrderAddMonoidIso.symm_comp_self			      <
OrderAddMonoidIso.symm_symm				      <
OrderAddMonoidIso.toEquiv_symm				      <
OrderMonoidIso.Simps.apply				      <
OrderMonoidIso.Simps.symm_apply				      <
OrderMonoidIso.apply_eq_iff_symm_apply			      <
OrderMonoidIso.apply_symm_apply				      <
OrderMonoidIso.coe_toEquiv_symm				      <
OrderMonoidIso.comp_symm_eq				      <
OrderMonoidIso.eq_comp_symm				      <
OrderMonoidIso.eq_symm_apply				      <
OrderMonoidIso.eq_symm_comp				      <
OrderMonoidIso.equivLike_inv_eq_symm			      <
OrderMonoidIso.invFun_eq_symm				      <
OrderMonoidIso.refl_symm				      <
OrderMonoidIso.self_comp_symm				      <
OrderMonoidIso.symm					      <
OrderMonoidIso.symm_apply_apply				      <
OrderMonoidIso.symm_apply_eq				      <
OrderMonoidIso.symm_bijective				      <
OrderMonoidIso.symm_comp_eq				      <
OrderMonoidIso.symm_comp_self				      <
OrderMonoidIso.symm_symm				      <
OrderMonoidIso.toEquiv_symm				      <
OrderMonoidIso.unitsWithZero_apply			      |	OrderMonoidIso.unitsWithZero_toFun
OrderMonoidIso.val_inv_unitsWithZero_symm_apply		      <
OrderMonoidIso.val_unitsWithZero_symm_apply		      <

@urkud
Copy link
Copy Markdown
Member

urkud commented Apr 7, 2025

Thanks! 🎉
bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Apr 7, 2025
mathlib-bors bot pushed a commit that referenced this pull request Apr 7, 2025
@pechersky
chore(Algebra/Order/Hom): initliaze simps for Order(Add)MonoidFoo (#2…
539cf97 
…2402)

and define `Order(Add)MonoidIso.symm`
bringing along a copy of lemmas from MulEquiv

clean up the simps
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 7, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Algebra/Order/Hom): initliaze simps for Order(Add)MonoidFoo [Merged by Bors] - chore(Algebra/Order/Hom): initliaze simps for Order(Add)MonoidFoo Apr 7, 2025
@mathlib-bors mathlib-bors bot closed this Apr 7, 2025
@mathlib-bors mathlib-bors bot deleted the pechersky/initialize-simps-order-monoid-iso branch April 7, 2025 16:44
@YaelDillies YaelDillies mentioned this pull request Apr 14, 2025
Open
tannerduve pushed a commit that referenced this pull request May 13, 2025
@pechersky @tannerduve
chore(Algebra/Order/Hom): initliaze simps for Order(Add)MonoidFoo (#2…
55fab41 
…2402)

and define `Order(Add)MonoidIso.symm`
bringing along a copy of lemmas from MulEquiv

clean up the simps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pechersky @urkud