Skip to content

[Merged by Bors] - refactor(RepresentationTheory/Rep): golf some proofs#22338

Closed
101damnations wants to merge 3 commits intomasterfrom
arlrepgolf
Closed

[Merged by Bors] - refactor(RepresentationTheory/Rep): golf some proofs#22338
101damnations wants to merge 3 commits intomasterfrom
arlrepgolf

Conversation

@101damnations
Copy link
Copy Markdown
Collaborator


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 26, 2025

PR summary 56612041ca

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ leftRegularHom_hom_single
+ tensor_ρ
+ β_hom_hom
+ β_inv_hom
- MonoidalCategory.braiding_hom_apply
- MonoidalCategory.braiding_inv_apply
- leftRegularHom_apply

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (4.00, 0.00)
Current number Change Type
3287 -4 porting notes
1266 -4 erw

Current commit 56612041ca
Reference commit ed6582d35a

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Copy Markdown
Contributor

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice golfs; I just was wondering if this can be golfed more. Perhaps it can't!

@kbuzzard
Copy link
Copy Markdown
Member

Thanks a lot!

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Feb 27, 2025
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 27, 2025

Merge conflict.

@kbuzzard
Copy link
Copy Markdown
Member

bors merge

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 27, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title refactor(RepresentationTheory/Rep): golf some proofs [Merged by Bors] - refactor(RepresentationTheory/Rep): golf some proofs Feb 27, 2025
@mathlib-bors mathlib-bors bot closed this Feb 27, 2025
@mathlib-bors mathlib-bors bot deleted the arlrepgolf branch February 27, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants