Skip to content

feat(RingTheory/GradedAlgebra): homogeneous relation#22279

Closed
xyzw12345 wants to merge 74 commits intomasterfrom
xyzw12345_HomogeneousRelation
Closed

feat(RingTheory/GradedAlgebra): homogeneous relation#22279
xyzw12345 wants to merge 74 commits intomasterfrom
xyzw12345_HomogeneousRelation

Conversation

@xyzw12345
Copy link
Copy Markdown
Collaborator

@xyzw12345 xyzw12345 commented Feb 25, 2025

In this PR, we defined the concept of a homogeneous relation and proved some properties about homogeneous relations. The main result of this PR is showing that taking RingQuot by a homogeneous relation can give a graded structure on the quotient ring. This result can be used to define graded structures on rings obtained using RingQuot, e.g. the Symmetric Algebra defined in #21539 can be verified to have such a structure.

Co-authored-by:
Zhixuan Dai @atstarrysky 22300180006@m.fudan.edu.cn
Yiming Fu @pelicanhere fakegreenall@foxmail.com
Zhenyan Fu @pumpkin678 fuzhenyan@mail.dlut.edu.cn
Raphael Douglas Giles @Raph-DG raphaeldouglasgiles@gmail.com
Jiedong Jiang @jjdishere emailboxofjjd@163.com


Open in Gitpod

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 5, 2025
@ocfnash ocfnash added the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 15, 2025
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 15, 2025
@pelicanhere pelicanhere removed the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 21, 2025
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Apr 2, 2025
@mathlib4-dependent-issues-bot
Copy link
Copy Markdown
Collaborator

@grunweg
Copy link
Copy Markdown
Contributor

grunweg commented May 8, 2025

Hello @ocfnash. On behalf of the reviewer auto-assignment algorithm, I'm assigning this PR to you.

@xyzw12345 xyzw12345 requested a review from ocfnash June 3, 2025 14:55
@ocfnash
Copy link
Copy Markdown
Contributor

ocfnash commented Jun 25, 2025

I like this PR and I'd like to get it resolved. Thank you all for the work so far!

Before we go further I think we need to settle some design decisions.

First, I have some remarks about existing definitions as follows:

  • TwoSidedIdeal Two-sided ideals, very general (in particular no commutativity / unitality assumed)
  • RingCon An implementation detail en route to TwoSidedIdeal
  • HomogenousIdeal Homogenous left ideals, expect only useful in commutative (unital) world
  • RingQuot A legacy adhoc construction, which we should phase out in favour of working with TwoSidedIdeal

Assuming I've got the above correct (ping @eric-wieser in case he has bandwidth to add some remarks) I believe two weaknesses of the current design are:

  • it uses the language of relations rather than ideals
  • it uses the legacy RingQuot

Bearing all of the above in mind, I have the following questions:

  1. Do we really want to have a notion of a homogeneous relation, that does not necessarily come from an ideal (or at least a submodule)?
  2. If the answer to 1 is "no", is there any reason why we should not work on top of TwoSidedIdeal rather than using relations and RingQuot? If so, it seems that HomogenousIdeal would provide some design inspiration, in particular using Submodule.IsHomogeneous. (In an ideal world we would not have both HomogenousIdeal and the hypothetical HomogenousTwoSidedIdeal, but this is part of a separate concern.)

@ocfnash ocfnash added the awaiting-author A reviewer has asked the author a question or requested changes. label Jun 25, 2025
@xyzw12345
Copy link
Copy Markdown
Collaborator Author

This PR has been migrated to a fork-based workflow: #27307

@xyzw12345 xyzw12345 closed this Jul 20, 2025
@YaelDillies YaelDillies deleted the xyzw12345_HomogeneousRelation branch August 17, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-author A reviewer has asked the author a question or requested changes. migrated-to-fork new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants