Skip to content

[Merged by Bors] - feat(LinearAlgebra): Symmetric Algebra#21539

Closed
Raph-DG wants to merge 84 commits intomasterfrom
Raph-DG-SymmetricAlgebra
Closed

[Merged by Bors] - feat(LinearAlgebra): Symmetric Algebra#21539
Raph-DG wants to merge 84 commits intomasterfrom
Raph-DG-SymmetricAlgebra

Conversation

@Raph-DG
Copy link
Copy Markdown
Collaborator

@Raph-DG Raph-DG commented Feb 7, 2025

Defined the universal property for the symmetric algebra of a module over a commutative ring, provided an explicit construction and proved that this satisfies the universal property. Also proved that the multivariate polynomial ring generated by a basis of a module satisfies the universal property of the symmetric algebra of that module.

Co-authored-by: Zhixuan Dai 22300180006@m.fudan.edu.cn
Co-authored-by: Zhenyan Fu fuzhenyan@mail.dlut.edu.cn
Co-authored-by: Yiming Fu fakegreenall@foxmail.com
Co-authored-by: Wang Jingting wangjt2020@163.com


Open in Gitpod

@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Feb 7, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 7, 2025

PR summary 74f4ad6ae9

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.LinearAlgebra.SymmetricAlgebra.Basic (new file) 1023
Mathlib.LinearAlgebra.SymmetricAlgebra.Basis (new file) 1329

Declarations diff

+ SymmetricAlgebra
+ TensorAlgebra.SymRel
+ _root_.Basis.symmetricAlgebra
+ algHom
+ algHom_ext
+ algHom_surjective
+ algebraMapInv
+ algebraMap_eq_one_iff
+ algebraMap_eq_zero_iff
+ algebraMap_inj
+ algebraMap_leftInverse
+ equivMvPolynomial
+ equivMvPolynomial_symm_X
+ equivMvPolynomial_ι_apply
+ induction
+ instIsDomain
+ instModuleFree
+ instNoZeroDivisors
+ instance (R M) [CommRing R] [AddCommMonoid M] [Module R M] : CommRing (SymmetricAlgebra R M)
+ instance : CommSemiring (SymmetricAlgebra R M)
+ instance [Nontrivial R] : Nontrivial (SymmetricAlgebra R M)
+ lift
+ lift_comp_ι
+ lift_ι
+ lift_ι_apply
+ rank_eq
+ ι

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Feb 7, 2025
I guess it's probably customary to write the names of Chinese people with first names coming first(?)
slight changes about indentation and other stuff
@Raph-DG Raph-DG requested a review from jcommelin February 10, 2025 16:08
@xyzw12345 xyzw12345 removed the awaiting-author A reviewer has asked the author a question or requested changes. label May 6, 2025
@xyzw12345 xyzw12345 requested a review from eric-wieser May 6, 2025 01:53
@eric-wieser
Copy link
Copy Markdown
Member

eric-wieser commented May 10, 2025

I copied across the algebraMapInv stuff from TensorAlgebra so that the Basis.lean file can be exactly in parity with the TensorAlgebra version, and tweaked some sectioning to make them match.

maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by eric-wieser.

1 similar comment
@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by eric-wieser.

Copy link
Copy Markdown
Member

@kbuzzard kbuzzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented May 10, 2025

✌️ Raph-DG can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels May 10, 2025
xyzw12345 and others added 2 commits May 11, 2025 13:21
Co-authored-by: Kevin Buzzard <k.buzzard@imperial.ac.uk>
@Raph-DG
Copy link
Copy Markdown
Collaborator Author

Raph-DG commented May 11, 2025

bors r+

mathlib-bors bot pushed a commit that referenced this pull request May 11, 2025
Defined the universal property for the symmetric algebra of a module over a commutative ring, provided an explicit construction and proved that this satisfies the universal property. Also proved that the multivariate polynomial ring generated by a basis of a module satisfies the universal property of the symmetric algebra of that module.

Co-authored-by: Zhixuan Dai <22300180006@m.fudan.edu.cn>
Co-authored-by: Zhenyan Fu <fuzhenyan@mail.dlut.edu.cn>
Co-authored-by: Yiming Fu <fakegreenall@foxmail.com>
Co-authored-by: Wang Jingting <wangjt2020@163.com>



Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented May 11, 2025

Build failed:

@Raph-DG
Copy link
Copy Markdown
Collaborator Author

Raph-DG commented May 11, 2025

bors r+

mathlib-bors bot pushed a commit that referenced this pull request May 11, 2025
Defined the universal property for the symmetric algebra of a module over a commutative ring, provided an explicit construction and proved that this satisfies the universal property. Also proved that the multivariate polynomial ring generated by a basis of a module satisfies the universal property of the symmetric algebra of that module.

Co-authored-by: Zhixuan Dai <22300180006@m.fudan.edu.cn>
Co-authored-by: Zhenyan Fu <fuzhenyan@mail.dlut.edu.cn>
Co-authored-by: Yiming Fu <fakegreenall@foxmail.com>
Co-authored-by: Wang Jingting <wangjt2020@163.com>



Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented May 11, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(LinearAlgebra): Symmetric Algebra [Merged by Bors] - feat(LinearAlgebra): Symmetric Algebra May 11, 2025
@mathlib-bors mathlib-bors bot closed this May 11, 2025
@mathlib-bors mathlib-bors bot deleted the Raph-DG-SymmetricAlgebra branch May 11, 2025 14:08
tannerduve pushed a commit that referenced this pull request May 13, 2025
Defined the universal property for the symmetric algebra of a module over a commutative ring, provided an explicit construction and proved that this satisfies the universal property. Also proved that the multivariate polynomial ring generated by a basis of a module satisfies the universal property of the symmetric algebra of that module.

Co-authored-by: Zhixuan Dai <22300180006@m.fudan.edu.cn>
Co-authored-by: Zhenyan Fu <fuzhenyan@mail.dlut.edu.cn>
Co-authored-by: Yiming Fu <fakegreenall@foxmail.com>
Co-authored-by: Wang Jingting <wangjt2020@163.com>



Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
bwehlin pushed a commit to bwehlin/mathlib4 that referenced this pull request May 31, 2025
Defined the universal property for the symmetric algebra of a module over a commutative ring, provided an explicit construction and proved that this satisfies the universal property. Also proved that the multivariate polynomial ring generated by a basis of a module satisfies the universal property of the symmetric algebra of that module.

Co-authored-by: Zhixuan Dai <22300180006@m.fudan.edu.cn>
Co-authored-by: Zhenyan Fu <fuzhenyan@mail.dlut.edu.cn>
Co-authored-by: Yiming Fu <fakegreenall@foxmail.com>
Co-authored-by: Wang Jingting <wangjt2020@163.com>



Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants