Skip to content

feat: simproc for Int.divisorsAntidiag#21915

Open
YaelDillies wants to merge 1 commit intomasterfrom
int_divisors_antidiag_simproc
Open

feat: simproc for Int.divisorsAntidiag#21915
YaelDillies wants to merge 1 commit intomasterfrom
int_divisors_antidiag_simproc

Conversation

@YaelDillies
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies commented Feb 15, 2025

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 15, 2025

PR summary 66b2a6571b

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ evalDivisorsAntidiag
+ evalNatDivisorsAntidiag

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Feb 15, 2025
Comment on lines +15 to +23
open
Qq
Lean
Meta
Simp
Elab
Term
Parser
Tactic
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a little unhinged, especially because the structure this implies does not reflect the actual behavior (this opens Lean.Elab.Tactic too)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am aware (and sad about it), but anyway this is still WIP and is currently here only for me to understand what's going on

@YaelDillies YaelDillies added WIP Work in progress t-meta Tactics, attributes or user commands labels Feb 15, 2025
@YaelDillies YaelDillies changed the base branch from int_divisors_antidiag to master February 15, 2025 16:44
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Feb 17, 2025
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 17, 2025
@YaelDillies YaelDillies force-pushed the int_divisors_antidiag_simproc branch from 43288d4 to d7c1f85 Compare February 17, 2025 13:34
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 17, 2025
@YaelDillies YaelDillies force-pushed the int_divisors_antidiag_simproc branch from d7c1f85 to 194a191 Compare February 17, 2025 14:20
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) and removed blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) labels Feb 17, 2025
@mathlib4-dependent-issues-bot
Copy link
Copy Markdown
Collaborator

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 25, 2025
@YaelDillies YaelDillies force-pushed the int_divisors_antidiag_simproc branch from 4a4101a to 7518519 Compare February 25, 2025 16:32
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 25, 2025
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 28, 2025
@YaelDillies YaelDillies force-pushed the int_divisors_antidiag_simproc branch from 7518519 to 59efd8d Compare February 28, 2025 15:00
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 28, 2025
mathlib-bors bot pushed a commit that referenced this pull request Apr 12, 2025
…22977)

This PR defines `Nat.divisorsAntidiagonalList` and proves a couple of basic results. 

This will be used in #21915 (adds a simproc to compute `Nat.divisorsAntidiagonal` and `Int.divisorsAntidiagonal`)



Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
mathlib-bors bot pushed a commit that referenced this pull request Apr 12, 2025
…22977)

This PR defines `Nat.divisorsAntidiagonalList` and proves a couple of basic results. 

This will be used in #21915 (adds a simproc to compute `Nat.divisorsAntidiagonal` and `Int.divisorsAntidiagonal`)



Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
tannerduve pushed a commit that referenced this pull request May 13, 2025
…22977)

This PR defines `Nat.divisorsAntidiagonalList` and proves a couple of basic results. 

This will be used in #21915 (adds a simproc to compute `Nat.divisorsAntidiagonal` and `Int.divisorsAntidiagonal`)



Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@leanprover-community-bot-assistant
Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 20, 2025
@YaelDillies YaelDillies force-pushed the int_divisors_antidiag_simproc branch 2 times, most recently from 67e9031 to af1d72f Compare July 25, 2025 14:01
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 25, 2025
@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 19, 2025
@mathlib4-merge-conflict-bot
Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@YaelDillies YaelDillies force-pushed the int_divisors_antidiag_simproc branch from af1d72f to 91d3d53 Compare November 19, 2025 11:16
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-meta Tactics, attributes or user commands WIP Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants