[Merged by Bors] - feat(CategoryTheory): reorganizing Over categories#21717
Closed
[Merged by Bors] - feat(CategoryTheory): reorganizing Over categories#21717
Conversation
This PR reorganizes related files to Over categories. In particular, it moves the files as follows: `CategoryTheory.Comma.Over` -> `Category.Comma.Over.Basic` `Comma.OverClass` -> `Comma.Over.OverClass`, `Adjunction.Over` -> Comma.Over.Pullback`.
PR summary 0e1da33302
|
| Files | Import difference |
|---|---|
Mathlib.CategoryTheory.Adjunction.Over |
-428 |
Mathlib.CategoryTheory.Comma.OverClass |
-386 |
Mathlib.CategoryTheory.Comma.Over |
-385 |
Mathlib.CategoryTheory.Comma.Over.Basic |
385 |
Mathlib.CategoryTheory.Comma.Over.OverClass |
386 |
Mathlib.CategoryTheory.Comma.Over.Pullback |
428 |
Declarations diff
No declarations were harmed in the making of this PR! 🐙
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
Contributor
|
Could you remove the new API from this PR? (It should only move things.) |
Collaborator
Author
Alright, if I have not missed anything, it should now just be renaming, and no new API from #21525. |
Contributor
|
Thanks! bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 11, 2025
This PR reorganizes related files to Over categories. In particular, it moves the files as follows: `CategoryTheory.Comma.Over` -> `Category.Comma.Over.Basic` `Comma.OverClass` -> `Comma.Over.OverClass`, `Adjunction.Over` -> `Comma.Over.Pullback`. This was motivated by the discussion in #21525.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reorganizes related files to Over categories. In particular, it moves the files as follows:
CategoryTheory.Comma.Over->Category.Comma.Over.BasicComma.OverClass->Comma.Over.OverClass,Adjunction.Over->Comma.Over.Pullback.This was motivated by the discussion in #21525.