Skip to content

[Merged by Bors] - refactor(CategoryTheory/Action/*): make Action.rho a MonoidHom instead of a morphism in MonCat#21652

Closed
101damnations wants to merge 15 commits intomasterfrom
actionmoncat
Closed

[Merged by Bors] - refactor(CategoryTheory/Action/*): make Action.rho a MonoidHom instead of a morphism in MonCat#21652
101damnations wants to merge 15 commits intomasterfrom
actionmoncat

Conversation

@101damnations
Copy link
Copy Markdown
Collaborator

@101damnations 101damnations commented Feb 10, 2025


A PR that replaces the MonCat morphism in the definition of Action with just a MonoidHom. This change was suggested to me a while ago by @joelriou as it's more universe polymorphic, although I didn't generalise the universes in this PR. I don't know if other people want this change but I'm opening it just in case, since I'm about to open a bunch of other PRs that currently depend on it (although I could find a way for them not to, if this PR is deemed unnecessary).

Open in Gitpod

@101damnations 101damnations added the WIP Work in progress label Feb 10, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 10, 2025

PR summary b9101beae5

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ instance : FiberFunctor (Action.forget FintypeCat G)
+ instance : FiberFunctor (forget₂ (Action FintypeCat G) FintypeCat)
+ instance : GaloisCategory (Action FintypeCat G)
+ instance : PreGaloisCategory (Action FintypeCat G)
+ instance : PreservesFiniteLimits (forget (Action FintypeCat G)) := by
+ instance [LeftRigidCategory V] : LeftRigidCategory (SingleObj H ⥤ V) := by
+ instance [RightRigidCategory V] : RightRigidCategory (SingleObj H ⥤ V) := by
+ instance [RigidCategory V] : RigidCategory (SingleObj H ⥤ V) := by
+ instance {G : Type u} [Monoid G] (X : Action FintypeCat G) : MulAction G X.V
+ instance {X Y : Action FintypeCat G} (f : X ⟶ Y) :
- instance : FiberFunctor (Action.forget FintypeCat (MonCat.of G))
- instance : FiberFunctor (forget₂ (Action FintypeCat (MonCat.of G)) FintypeCat)
- instance : GaloisCategory (Action FintypeCat (MonCat.of G))
- instance : PreGaloisCategory (Action FintypeCat (MonCat.of G))
- instance : PreservesFiniteLimits (forget (Action FintypeCat (MonCat.of G))) := by
- instance [LeftRigidCategory V] : LeftRigidCategory (SingleObj (H : MonCat.{u}) ⥤ V) := by
- instance [RightRigidCategory V] : RightRigidCategory (SingleObj (H : MonCat.{u}) ⥤ V) := by
- instance [RigidCategory V] : RigidCategory (SingleObj (H : MonCat.{u}) ⥤ V) := by
- instance {G : MonCat.{u}} (X : Action FintypeCat G) : MulAction G X.V := Action.instMulAction X
- instance {G : Type u} [Group G] (X : Action FintypeCat (MonCat.of G)) : MulAction G X.V
- instance {X Y : Action FintypeCat (MonCat.of G)} (f : X ⟶ Y) :
- of_ρ_apply
- tensorUnit_ρ'
- tensor_ρ'

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (1.00, 0.00)
Current number Change Type
1305 -1 erw

Current commit b9101beae5
Reference commit 42e56d7453

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@joelriou
Copy link
Copy Markdown
Contributor

Thanks!

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Feb 23, 2025
mathlib-bors bot pushed a commit that referenced this pull request Feb 23, 2025
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 23, 2025

Build failed:

@TwoFX
Copy link
Copy Markdown
Member

TwoFX commented Feb 25, 2025

Let's try this again:
bors r+

mathlib-bors bot pushed a commit that referenced this pull request Feb 25, 2025
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 25, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title refactor(CategoryTheory/Action/*): make Action.rho a MonoidHom instead of a morphism in MonCat [Merged by Bors] - refactor(CategoryTheory/Action/*): make Action.rho a MonoidHom instead of a morphism in MonCat Feb 25, 2025
@mathlib-bors mathlib-bors bot closed this Feb 25, 2025
@mathlib-bors mathlib-bors bot deleted the actionmoncat branch February 25, 2025 20:38
mathlib-bors bot pushed a commit that referenced this pull request May 2, 2025
Since #21652 the universe restrictions are no longer necessary. This also allows to remove some universe restrictions in the Galois category API.
pfaffelh pushed a commit that referenced this pull request May 2, 2025
Since #21652 the universe restrictions are no longer necessary. This also allows to remove some universe restrictions in the Galois category API.
riccardobrasca pushed a commit that referenced this pull request May 7, 2025
Since #21652 the universe restrictions are no longer necessary. This also allows to remove some universe restrictions in the Galois category API.
tannerduve pushed a commit that referenced this pull request May 13, 2025
Since #21652 the universe restrictions are no longer necessary. This also allows to remove some universe restrictions in the Galois category API.
This was referenced Jun 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants