Skip to content

[Merged by Bors] - feat(CategoryTheory/MorphismProperty/LiftingProperty): more API for llp and rlp#21597

Closed
joelriou wants to merge 7 commits intomasterfrom
jriou-morphismproperty-rlp-llp-more-api
Closed

[Merged by Bors] - feat(CategoryTheory/MorphismProperty/LiftingProperty): more API for llp and rlp#21597
joelriou wants to merge 7 commits intomasterfrom
jriou-morphismproperty-rlp-llp-more-api

Conversation

@joelriou
Copy link
Copy Markdown
Contributor

@joelriou joelriou commented Feb 9, 2025 •
edited
Loading

We show that rlp and llp form a Galois connection, and we deduce some consequences.

Open in Gitpod

@joelriou joelriou added the t-category-theory Category theory label Feb 9, 2025
@joelriou joelriou mentioned this pull request Feb 9, 2025
Closed
21 tasks
@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Feb 9, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 9, 2025 •
edited
Loading

PR summary 05bdd380d3

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ antitone_llp
+ antitone_rlp
+ colimitsOfShape_discrete_le_llp_rlp
+ coproducts_le_llp_rlp
+ gc_llp_rlp
+ le_llp_iff_le_rlp
+ le_llp_rlp
+ llp_isStableUnderCoproductsOfShape
+ llp_rlp_llp
+ pushouts_le_llp_rlp
+ retracts_le_llp_rlp
+ rlp_coproducts
+ rlp_isStableUnderProductsOfShape
+ rlp_llp_rlp
+ rlp_pushouts
+ rlp_retracts
- llp_IsStableUnderCoproductsOfShape
- rlp_IsStableUnderProductsOfShape

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Feb 9, 2025
TwoFX
TwoFX reviewed Feb 9, 2025
View reviewed changes
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Feb 9, 2025
@mathlib4-dependent-issues-bot
Copy link
Copy Markdown
Collaborator

mathlib4-dependent-issues-bot commented Feb 9, 2025

This PR/issue depends on:

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 9, 2025
@github-actions github-actions bot removed merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) large-import Automatically added label for PRs with a significant increase in transitive imports labels Feb 9, 2025
TwoFX
TwoFX approved these changes Feb 10, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@TwoFX TwoFX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors r+

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Feb 10, 2025
mathlib-bors bot pushed a commit that referenced this pull request Feb 10, 2025
@joelriou
feat(CategoryTheory/MorphismProperty/LiftingProperty): more API for l…
942265a 
…lp and rlp (#21597)

We show that `rlp` and `llp` form a Galois connection, and we deduce some consequences.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 10, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(CategoryTheory/MorphismProperty/LiftingProperty): more API for llp and rlp [Merged by Bors] - feat(CategoryTheory/MorphismProperty/LiftingProperty): more API for llp and rlp Feb 10, 2025
@mathlib-bors mathlib-bors bot closed this Feb 10, 2025
@mathlib-bors mathlib-bors bot deleted the jriou-morphismproperty-rlp-llp-more-api branch February 10, 2025 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TwoFX TwoFX TwoFX approved these changes

Assignees

No one assigned

Labels

ready-to-merge This PR has been sent to bors. t-category-theory Category theory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joelriou @mathlib4-dependent-issues-bot @TwoFX @leanprover-community-bot-assistant