Skip to content

[Merged by Bors] - feat: remove nonemptiness assumption for the sum of manifolds#21500

Closed
sgouezel wants to merge 4 commits intomasterfrom
SG_sum_manifold
Closed

[Merged by Bors] - feat: remove nonemptiness assumption for the sum of manifolds#21500
sgouezel wants to merge 4 commits intomasterfrom
SG_sum_manifold

Conversation

@sgouezel
Copy link
Copy Markdown
Contributor

@sgouezel sgouezel commented Feb 6, 2025

Open in Gitpod

@sgouezel sgouezel added the t-differential-geometry Manifolds etc label Feb 6, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 6, 2025 •
edited
Loading

PR summary 1b5f1ba13e

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ ChartedSpace.sum_of_nonempty
+ contMDiffAt_of_subsingleton
+ contMDiffOn_of_subsingleton
+ contMDiffWithinAt_of_subsingleton
+ contMDiff_of_subsingleton
+ isEmpty_of_chartedSpace
+ nonempty_of_chartedSpace
+ sum_chartAt_inl_apply
+ sum_chartAt_inr_apply

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@sgouezel sgouezel mentioned this pull request Feb 6, 2025
Closed
2 tasks
@grunweg grunweg self-assigned this Feb 7, 2025
grunweg
grunweg reviewed Feb 10, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks very nice! I have only minor comments.
maintainer delegate

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 10, 2025

🚀 Pull request has been placed on the maintainer queue by grunweg.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Feb 10, 2025
@ocfnash
Copy link
Copy Markdown
Contributor

ocfnash commented Feb 10, 2025

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 10, 2025

✌️ sgouezel can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Feb 10, 2025
@sgouezel
Copy link
Copy Markdown
Contributor Author

sgouezel commented Feb 11, 2025

bors r+

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Feb 11, 2025
mathlib-bors bot pushed a commit that referenced this pull request Feb 11, 2025
@sgouezel
feat: remove nonemptiness assumption for the sum of manifolds (#21500)
c928780
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 11, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: remove nonemptiness assumption for the sum of manifolds [Merged by Bors] - feat: remove nonemptiness assumption for the sum of manifolds Feb 11, 2025
@mathlib-bors mathlib-bors bot closed this Feb 11, 2025
@mathlib-bors mathlib-bors bot deleted the SG_sum_manifold branch February 11, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grunweg grunweg grunweg left review comments

Assignees

@grunweg grunweg

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors. t-differential-geometry Manifolds etc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sgouezel @ocfnash @grunweg