[Merged by Bors] - refactor(Topology/Constructible): use QuasiSeparatedSpace#21325
Closed
YaelDillies wants to merge 3 commits intomasterfrom
Closed
[Merged by Bors] - refactor(Topology/Constructible): use QuasiSeparatedSpace#21325YaelDillies wants to merge 3 commits intomasterfrom
QuasiSeparatedSpace#21325YaelDillies wants to merge 3 commits intomasterfrom
Conversation
A few lemmas took assumptions of the form`IsTopologicalBasis (range b)` + `∀ i j, IsCompact (b i ∩ b j)`. But this is equivalent to the more natural set of assumptions `IsTopologicalBasis (range b)` + `∀ i, IsCompact (b i)` + `QuasiSeparatedSpace X`. Also link to [Stacks 0069](https://stacks.math.columbia.edu/tag/0069).
QuasiSeparatedSpace QuasiSeparatedSpace
PR summary f0afbe0f4fImport changes exceeding 2%
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Topology.Constructible | 726 | 744 | +18 (+2.48%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.Topology.Constructible |
18 |
Declarations diff
+ IsCompact.inter_of_isOpen
+ QuasiSeparatedSpace.of_isTopologicalBasis
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
1 task
alreadydone
reviewed
Feb 1, 2025
alreadydone
approved these changes
Feb 1, 2025
Contributor
alreadydone
left a comment
There was a problem hiding this comment.
Thanks 🎉
maintainer merge
(this is a recent leaf file so I won't worry about import increase)
|
🚀 Pull request has been placed on the maintainer queue by alreadydone. |
Contributor
Author
|
I think it would make sense to split the file to avoid the import increase, but at this point in time it feels premature and I would rather wait to see what a meaningful split would be. |
jcommelin
reviewed
Feb 3, 2025
Member
jcommelin
left a comment
There was a problem hiding this comment.
Thanks 🎉
If CI passes, please remove the label awaiting-CI and merge this yourself, by adding a comment bors r+.
bors d+
Contributor
|
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
Author
|
CI already passes 😁 bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 3, 2025
A few lemmas took assumptions of the form`IsTopologicalBasis (range b)` + `∀ i j, IsCompact (b i ∩ b j)`. But this is equivalent to the more natural set of assumptions `IsTopologicalBasis (range b)` + `∀ i, IsCompact (b i)` + `QuasiSeparatedSpace X`. Also link to [Stacks 0069](https://stacks.math.columbia.edu/tag/0069).
Contributor
|
Pull request successfully merged into master. Build succeeded: |
QuasiSeparatedSpaceQuasiSeparatedSpace
YaelDillies
added a commit
that referenced
this pull request
Feb 3, 2025
Also golf the `QuasiSeparatedSpace` instance for affine schemes (the common proof was abstracted out i #21325) and prove that open sets are retrocompact iff they are compact (this should eventually become a lemma about spectral spaces).
jt496
pushed a commit
that referenced
this pull request
Feb 3, 2025
A few lemmas took assumptions of the form`IsTopologicalBasis (range b)` + `∀ i j, IsCompact (b i ∩ b j)`. But this is equivalent to the more natural set of assumptions `IsTopologicalBasis (range b)` + `∀ i, IsCompact (b i)` + `QuasiSeparatedSpace X`. Also link to [Stacks 0069](https://stacks.math.columbia.edu/tag/0069).
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 4, 2025
Also golf the `QuasiSeparatedSpace` instance for affine schemes (the common proof was abstracted out in #21325) and prove that open sets are retrocompact iff they are compact (this should eventually become a lemma about spectral spaces).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few lemmas took assumptions of the form
IsTopologicalBasis (range b)+∀ i j, IsCompact (b i ∩ b j). But this is equivalent to the more natural set of assumptionsIsTopologicalBasis (range b)+∀ i, IsCompact (b i)+QuasiSeparatedSpace X.Also link to Stacks 0069.