Skip to content

[Merged by Bors] - chore(NonZeroDivisors): clean up#21288

Closed
YaelDillies wants to merge 1 commit intomasterfrom
cleanup_non_zero_divisors
Closed

[Merged by Bors] - chore(NonZeroDivisors): clean up#21288
YaelDillies wants to merge 1 commit intomasterfrom
cleanup_non_zero_divisors

Conversation

@YaelDillies
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies commented Jan 31, 2025

Follow-up to #20871, which was only code moves.


Open in Gitpod

@YaelDillies YaelDillies changed the base branch from non_zero_divisors_no_ring to master January 31, 2025 11:58
@YaelDillies YaelDillies changed the title Cleanup_non_zero_divisors chore(NonZeroDivisors): clean up Jan 31, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 31, 2025

PR summary 8033a8c2fb

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Jan 31, 2025
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Jan 31, 2025
@YaelDillies YaelDillies force-pushed the cleanup_non_zero_divisors branch from 74dcd5f to 6e44269 Compare January 31, 2025 15:31
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Jan 31, 2025
@mathlib4-dependent-issues-bot
Copy link
Copy Markdown
Collaborator

This PR/issue depends on:

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 4, 2025
Follow-up to #20871, which was only code moves.
@YaelDillies YaelDillies force-pushed the cleanup_non_zero_divisors branch from cd0a081 to 8033a8c Compare February 4, 2025 13:21
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 4, 2025
@riccardobrasca
Copy link
Copy Markdown
Member

Thanks!

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Feb 14, 2025
mathlib-bors bot pushed a commit that referenced this pull request Feb 14, 2025
Follow-up to #20871, which was only code moves.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 14, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(NonZeroDivisors): clean up [Merged by Bors] - chore(NonZeroDivisors): clean up Feb 14, 2025
@mathlib-bors mathlib-bors bot closed this Feb 14, 2025
@mathlib-bors mathlib-bors bot deleted the cleanup_non_zero_divisors branch February 14, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants