[Merged by Bors] - feat(*/Fin/*): add 2 lemmas#21229
Closed
Conversation
PR summary ea27533810Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
Ruben-VandeVelde
approved these changes
Jan 29, 2025
Contributor
Ruben-VandeVelde
left a comment
There was a problem hiding this comment.
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
adomani
reviewed
Jan 29, 2025
| eq_comm.trans zero_eq_top | ||
|
|
||
| @[simp] | ||
| theorem cast_top {m n : ℕ} [NeZero m] [NeZero n] (h : m = n) : (⊤ : Fin m).cast h = ⊤ := by |
Contributor
There was a problem hiding this comment.
Funky that you need both NeZero assumptions, even with the m = n: I see where it comes from, but still find it amusing!
Thanks!
bors merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 29, 2025
This is a version of #21112 that doesn't use inline `NeZero` instances, thus doesn't break `simp` normal forms all over the place.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
jt496
pushed a commit
that referenced
this pull request
Feb 3, 2025
This is a version of #21112 that doesn't use inline `NeZero` instances, thus doesn't break `simp` normal forms all over the place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a version of #21112 that doesn't use inline
NeZeroinstances, thus doesn't breaksimpnormal forms all over the place.