Skip to content

[Merged by Bors] - chore(Geometry/Manifold): create IsManifold directory#21218

Closed
grunweg wants to merge 1 commit intomasterfrom
MR-move-ismanifold
Closed

[Merged by Bors] - chore(Geometry/Manifold): create IsManifold directory#21218
grunweg wants to merge 1 commit intomasterfrom
MR-move-ismanifold

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Jan 29, 2025

Rename IsManifold.lean to IsManifold/Basic.lean, in preparating for a future commit splitting this file into several.
Move InteriorBoundary.lean to this new directory.


Open in Gitpod

@grunweg grunweg added awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. t-differential-geometry Manifolds etc tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip labels Jan 29, 2025
Rename IsManifold.lean to IsManifold/Basic.lean, in preparating for a future
commit splitting this file into several.
Move InteriorBoundary.lean to this new directory.
@grunweg grunweg force-pushed the MR-move-ismanifold branch from 3385fbf to 2b6e043 Compare January 29, 2025 13:20
@github-actions
Copy link
Copy Markdown

PR summary 2b6e043e94

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Geometry.Manifold.InteriorBoundary -1768
Mathlib.Geometry.Manifold.IsManifold -1767
Mathlib.Geometry.Manifold.IsManifold.Basic 1767
Mathlib.Geometry.Manifold.IsManifold.InteriorBoundary 1768

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jan 29, 2025
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Jan 29, 2025
mathlib-bors bot pushed a commit that referenced this pull request Jan 29, 2025
Rename IsManifold.lean to IsManifold/Basic.lean, in preparating for a future commit splitting this file into several.
Move InteriorBoundary.lean to this new directory.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 29, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Geometry/Manifold): create IsManifold directory [Merged by Bors] - chore(Geometry/Manifold): create IsManifold directory Jan 29, 2025
@mathlib-bors mathlib-bors bot closed this Jan 29, 2025
@mathlib-bors mathlib-bors bot deleted the MR-move-ismanifold branch January 29, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-differential-geometry Manifolds etc tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants