Skip to content

[Merged by Bors] - chore: antisymm_reflAntisymm.refl#21202

Closed
vihdzp wants to merge 7 commits intomasterfrom
vi.antisymmRel_depr
Closed

[Merged by Bors] - chore: antisymm_reflAntisymm.refl#21202
vihdzp wants to merge 7 commits intomasterfrom
vi.antisymmRel_depr

Conversation

@vihdzp
Copy link
Copy Markdown
Collaborator

@vihdzp vihdzp commented Jan 29, 2025

This allows us to use anonymous dot notation. Along the way, we also fix the argument implicitness of AntisymmRel.rfl.


Open in Gitpod

@vihdzp vihdzp added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. t-order Order theory labels Jan 29, 2025
@vihdzp vihdzp requested a review from YaelDillies January 29, 2025 00:47
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 29, 2025

PR summary dbeb763346

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ AntisymmRel.refl

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jan 29, 2025
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer delegate

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jan 29, 2025
Copy link
Copy Markdown
Contributor

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 30, 2025

✌️ vihdzp can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Jan 30, 2025
@vihdzp
Copy link
Copy Markdown
Collaborator Author

vihdzp commented Feb 8, 2025

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Feb 8, 2025
This allows us to use anonymous dot notation. Along the way, we also fix the argument implicitness of `AntisymmRel.rfl`.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 8, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: antisymm_reflAntisymm.refl [Merged by Bors] - chore: antisymm_reflAntisymm.refl Feb 8, 2025
@mathlib-bors mathlib-bors bot closed this Feb 8, 2025
@mathlib-bors mathlib-bors bot deleted the vi.antisymmRel_depr branch February 8, 2025 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). easy < 20s of review time. See the lifecycle page for guidelines. t-order Order theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants