Skip to content

[Merged by Bors] - chore(Perm/Fin): generalize from Fin n.succ to Fin n#21193

Closed
urkud wants to merge 1 commit intomasterfrom
YK-perm-fin
Closed

[Merged by Bors] - chore(Perm/Fin): generalize from Fin n.succ to Fin n#21193
urkud wants to merge 1 commit intomasterfrom
YK-perm-fin

Conversation

@urkud
Copy link
Copy Markdown
Member

@urkud urkud commented Jan 28, 2025

... adding [NeZero n] as needed.

Cherry-picked from #21112


Open in Gitpod

... adding `[NeZero n]` as needed.
@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Jan 28, 2025
@github-actions
Copy link
Copy Markdown

PR summary 40dc41aa44

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ cycleRange_mk_zero

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Copy Markdown
Contributor

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by grunweg.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jan 28, 2025
@urkud urkud mentioned this pull request Jan 29, 2025
3 tasks
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Jan 29, 2025
mathlib-bors bot pushed a commit that referenced this pull request Jan 29, 2025
... adding `[NeZero n]` as needed.

Cherry-picked from #21112
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 29, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Perm/Fin): generalize from Fin n.succ to Fin n [Merged by Bors] - chore(Perm/Fin): generalize from Fin n.succ to Fin n Jan 29, 2025
@mathlib-bors mathlib-bors bot closed this Jan 29, 2025
@mathlib-bors mathlib-bors bot deleted the YK-perm-fin branch January 29, 2025 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants