Skip to content

[Merged by Bors] - feat(*/Fin/*): add lemmas#21175

Closed
urkud wants to merge 1 commit intomasterfrom
YK-fin-lemmas-new
Closed

[Merged by Bors] - feat(*/Fin/*): add lemmas#21175
urkud wants to merge 1 commit intomasterfrom
YK-fin-lemmas-new

Conversation

@urkud
Copy link
Copy Markdown
Member

@urkud urkud commented Jan 28, 2025

Cherry-picked parts of #21112 that don't rely on a decision
about inline haveI : NeZero n := _

Open in Gitpod

@urkud
feat(*/Fin/*): add lemmas
8b7373e 
Cherry-picked parts of #21112 that don't rely on a decision
about inline `haveI : NeZero n := _`
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 28, 2025

PR summary 8b7373e452

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ cast_inj
+ succOrderEmb_toEmbedding
+ succ_top
+ top_eq_zero
+ val_top
+ zero_eq_top

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@urkud urkud added t-order Order theory t-data Data (lists, quotients, numbers, etc) labels Jan 28, 2025
@urkud urkud mentioned this pull request Jan 28, 2025
Closed
3 tasks
grunweg
grunweg reviewed Jan 28, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 28, 2025

🚀 Pull request has been placed on the maintainer queue by grunweg.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jan 28, 2025
jcommelin
jcommelin reviewed Jan 28, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Jan 28, 2025
mathlib-bors bot pushed a commit that referenced this pull request Jan 28, 2025
@urkud
feat(*/Fin/*): add lemmas (#21175)
3d93b8d 
Cherry-picked parts of #21112 that don't rely on a decision
about inline `haveI : NeZero n := _`
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 28, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(*/Fin/*): add lemmas [Merged by Bors] - feat(*/Fin/*): add lemmas Jan 28, 2025
@mathlib-bors mathlib-bors bot closed this Jan 28, 2025
@mathlib-bors mathlib-bors bot deleted the YK-fin-lemmas-new branch January 28, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcommelin jcommelin jcommelin left review comments

@grunweg grunweg grunweg left review comments

Assignees

No one assigned

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors. t-data Data (lists, quotients, numbers, etc) t-order Order theory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@urkud @jcommelin @grunweg