Skip to content

[Merged by Bors] - feat(Order): Fin.orderHom_injective_iff#21119

Closed
joelriou wants to merge 7 commits intomasterfrom
jriou-fin-monotone
Closed

[Merged by Bors] - feat(Order): Fin.orderHom_injective_iff#21119
joelriou wants to merge 7 commits intomasterfrom
jriou-fin-monotone

Conversation

@joelriou
Copy link
Copy Markdown
Contributor

@joelriou joelriou commented Jan 27, 2025

This PR adds a lemma Fin.orderHom_injective_iff which says that a monotone map f : Fin (n + 1) →o α is injective iff f i.castSucc ≠ f i.succ for all i.


Open in Gitpod

@joelriou joelriou added the t-order Order theory label Jan 27, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 27, 2025

PR summary de10c3e088

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ orderHom_injective_iff

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@joelriou
Copy link
Copy Markdown
Contributor Author

joelriou commented Jan 27, 2025

Thanks very much @mo271 for pointing out the duplicates. I have moved the only new lemma orderHom_injective_iff (with a better proof) to Order.Fin.Basic.

@joelriou joelriou changed the title feat(Order/Fin): monotone maps from Fin feat(Order): Fin.orderHom_injective_iff Jan 27, 2025
Co-authored-by: Moritz Firsching <firsching@google.com>
@[simps!] def predAboveOrderHom (p : Fin n) : Fin (n + 1) →o Fin n :=
⟨p.predAbove, p.predAbove_right_monotone⟩

lemma orderHom_injective_iff {α : Type*} [PartialOrder α] {n : ℕ} (f : Fin (n + 1) →o α) :
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YaelDillies it looks like this one might have a generalisation in terms of succ orders: do you know if that exists already?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it doesn't. It would belong after strictMono_iff_lt_succ

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have moved the lemma upwards in the file.

joelriou and others added 2 commits January 28, 2025 14:25
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Copy link
Copy Markdown
Contributor

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm now

maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jan 28, 2025
@jcommelin
Copy link
Copy Markdown
Member

Thanks 🎉

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Jan 29, 2025
mathlib-bors bot pushed a commit that referenced this pull request Jan 29, 2025
This PR adds a lemma `Fin.orderHom_injective_iff` which says that a monotone map `f : Fin (n + 1) →o α` is injective iff `f i.castSucc ≠ f i.succ` for all `i`.



Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 29, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Order): Fin.orderHom_injective_iff [Merged by Bors] - feat(Order): Fin.orderHom_injective_iff Jan 29, 2025
@mathlib-bors mathlib-bors bot closed this Jan 29, 2025
@mathlib-bors mathlib-bors bot deleted the jriou-fin-monotone branch January 29, 2025 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors. t-order Order theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants