chore(SetTheory/Game/PGame): Equiv → AntisymmRel#21086
Closed
chore(SetTheory/Game/PGame): Equiv → AntisymmRel#21086
Equiv → AntisymmRel#21086Conversation
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
This was referenced Jan 29, 2025
tristan-f-r
approved these changes
Jan 31, 2025
Collaborator
tristan-f-r
left a comment
There was a problem hiding this comment.
I conceptually have no problem with this: redefining Equiv in this way is better towards the goal of better Game generalizations. I don't have any extra comments because I can't spot anything wrong with any of the formalization refactors, but I'm not experienced in that regard.
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 4, 2025
This is needed for #21086.
Collaborator
Collaborator
Author
|
Moved to the combinatorial games repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We replace
PGame.Equivby the more generalAntisymmRel. This is part of #19588.We've kept both the setoid notation
≈, as well asequivwithin theorem names. We've deprecated any results that are more generally true on preorders, save for those onLFwhich will be dealt with separately.AntisymmRellemmas #19571simptoSetoid.refl#21107Although we can now define
Game = Antisymmetrization PGame (· ≤ ·), doing so means that⟦x⟧notation breaks. Given that we can still useinstPartialOrderAntisymmetrizationto declare the partial order instance, it might not even be worth to do this redefinition. In any case, that probably should be discussed separately.