Skip to content

[Merged by Bors] - chore(Algebra/GroupWithZero/Units/Basic): drop unnecessary porting note#20975

Closed
tristan-f-r wants to merge 1 commit intomasterfrom
tristanfr.quick-fix-port-basic
Closed

[Merged by Bors] - chore(Algebra/GroupWithZero/Units/Basic): drop unnecessary porting note#20975
tristan-f-r wants to merge 1 commit intomasterfrom
tristanfr.quick-fix-port-basic

Conversation

@tristan-f-r
Copy link
Copy Markdown
Collaborator

rfl after simp_rw applied to the regular lean codebase in #1096; the porting note is now outdated.


Open in Gitpod

rfl after simp_rw applied to the regular lean codebase in #1096; the porting note is now outdated.
@tristan-f-r tristan-f-r added easy < 20s of review time. See the lifecycle page for guidelines. t-algebra Algebra (groups, rings, fields, etc) labels Jan 23, 2025
@tristan-f-r tristan-f-r marked this pull request as ready for review January 23, 2025 07:20
@github-actions
Copy link
Copy Markdown

PR summary 45d721e292

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (1.00, 0.00)
Current number Change Type
4313 -1 porting notes

Current commit 45d721e292
Reference commit 3dc2beffa4

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@tristan-f-r tristan-f-r added the tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip label Jan 23, 2025
@grunweg
Copy link
Copy Markdown
Contributor

grunweg commented Jan 23, 2025

Thanks!
maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by grunweg.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jan 23, 2025
@riccardobrasca
Copy link
Copy Markdown
Member

Thanks!

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Jan 23, 2025
mathlib-bors bot pushed a commit that referenced this pull request Jan 23, 2025
…te (#20975)

rfl after simp_rw applied to the regular lean codebase in #1096; the porting note is now outdated.




Co-authored-by: Tristan F. <LeoDog896@hotmail.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 23, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Algebra/GroupWithZero/Units/Basic): drop unnecessary porting note [Merged by Bors] - chore(Algebra/GroupWithZero/Units/Basic): drop unnecessary porting note Jan 23, 2025
@mathlib-bors mathlib-bors bot closed this Jan 23, 2025
@mathlib-bors mathlib-bors bot deleted the tristanfr.quick-fix-port-basic branch January 23, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc) tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants