[Merged by Bors] - fix: add missing MonoidAlgebra.smul_single#20933
Closed
eric-wieser wants to merge 7 commits intomasterfrom
Closed
[Merged by Bors] - fix: add missing MonoidAlgebra.smul_single#20933eric-wieser wants to merge 7 commits intomasterfrom
MonoidAlgebra.smul_single#20933eric-wieser wants to merge 7 commits intomasterfrom
Conversation
This eliminates some `erw`s. Also fixes a bad simp lemma about `singleOneRingHom`.
PR summary 8ed36a4fdaImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for Decrease in tech debt: (relative, absolute) = (1.00, 0.00)
Current commit 8ed36a4fda You can run this locally as
|
1 task
mistarro
reviewed
Jan 22, 2025
Contributor
|
Thanks! bors d+ |
Contributor
|
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
Member
Author
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 23, 2025
This eliminates some `erw`s. Also fixes bad generated simp lemmas about `singleOneRingHom` and `singleZeroRingHom`, which previously included unwanted `toFun` terms.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
MonoidAlgebra.smul_singleMonoidAlgebra.smul_single
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This eliminates some
erws.Also fixes bad generated simp lemmas about
singleOneRingHomandsingleZeroRingHom, which previously included unwantedtoFunterms.