Skip to content

[Merged by Bors] - feat(CategoryTheory): Subpresheaf is a complete lattice#20840

Closed
joelriou wants to merge 13 commits intomasterfrom
subpresheaf-complete-lattice
Closed

[Merged by Bors] - feat(CategoryTheory): Subpresheaf is a complete lattice#20840
joelriou wants to merge 13 commits intomasterfrom
subpresheaf-complete-lattice

Conversation

@joelriou
Copy link
Copy Markdown
Contributor

@joelriou joelriou commented Jan 19, 2025

The type of subpresheaves of a given presheaf of sets is a complete lattice.


The large-import warning can be ignored because it is only related to the import of the definition of what a complete lattice is.

Open in Gitpod

@joelriou joelriou added the t-category-theory Category theory label Jan 19, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 19, 2025

PR summary 0618886c3d

Import changes exceeding 2%

% File
+16.67% Mathlib.CategoryTheory.Subpresheaf.Basic

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.CategoryTheory.Subpresheaf.Basic 342 399 +57 (+16.67%)
Import changes for all files
Files Import difference
Mathlib.CategoryTheory.Subpresheaf.Image 4
Mathlib.CategoryTheory.Subpresheaf.Basic 57

Declarations diff

+ bot_obj
+ eq_top_iff_isIso
+ homOfLe
+ homOfLe_ι
+ iInf_obj
+ iSup_min
+ iSup_obj
+ instance : CompleteLattice (Subpresheaf F)
+ le_def
+ max_min
+ max_obj
+ min_obj
+ nat_trans_naturality
+ sInf_obj
+ sSup_obj
+ toPresheaf
+ top_obj
+ ι
- Subpresheaf.eq_top_iff_isIso
- Subpresheaf.homOfLe
- Subpresheaf.homOfLe_ι
- Subpresheaf.le_def
- Subpresheaf.nat_trans_naturality
- Subpresheaf.toPresheaf
- Subpresheaf.ι
- instance : Top (Subpresheaf F)

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@joelriou joelriou added the WIP Work in progress label Jan 23, 2025
@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Jan 23, 2025
@joelriou joelriou removed the WIP Work in progress label Jan 23, 2025
mathlib-bors bot pushed a commit that referenced this pull request Jan 24, 2025
This PR only splits the file `AlgebraicTopology.SimplicialSet.Basic` by creating three new files `StdSimplex`, `Boundary`, `Horn`. This prepares for a refactor and future developments of API for these simplicial sets. For example, the boundary and the horn should be redefined (keeping the defeq) as subcomplexes of the standard simplex using the `Subpresheaf` API, see #20840.
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 27, 2025
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Jan 29, 2025
mathlib-bors bot pushed a commit that referenced this pull request Jan 29, 2025
The type of subpresheaves of a given presheaf of sets is a complete lattice.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 29, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(CategoryTheory): Subpresheaf is a complete lattice [Merged by Bors] - feat(CategoryTheory): Subpresheaf is a complete lattice Jan 29, 2025
@mathlib-bors mathlib-bors bot closed this Jan 29, 2025
@mathlib-bors mathlib-bors bot deleted the subpresheaf-complete-lattice branch January 29, 2025 09:37
mathlib-bors bot pushed a commit that referenced this pull request Mar 14, 2025
…21090)

Some new API is introduced for subcomplexes of the standard simplex: any `S : Finset (Fin (n + 1))` defines a subcomplex `face S` of `Δ[n]`, and this face is isomorphic to `Δ[m]` when `Fin (m + 1) ≃o S`. Then, boundaries and horns are redefined as subcomplexes of the standard simplex and it is shown that they are unions of certain codimension one faces of the standard simplex.

- [x] depends on: #21543
- [x] depends on: #21540
- [x] depends on: #21542
- [x] depends on: #21303
- [x] depends on: #21047
- [x] depends on: #20840
- [x] depends on: #21096 



Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
tukamilano pushed a commit that referenced this pull request Mar 20, 2025
…21090)

Some new API is introduced for subcomplexes of the standard simplex: any `S : Finset (Fin (n + 1))` defines a subcomplex `face S` of `Δ[n]`, and this face is isomorphic to `Δ[m]` when `Fin (m + 1) ≃o S`. Then, boundaries and horns are redefined as subcomplexes of the standard simplex and it is shown that they are unions of certain codimension one faces of the standard simplex.

- [x] depends on: #21543
- [x] depends on: #21540
- [x] depends on: #21542
- [x] depends on: #21303
- [x] depends on: #21047
- [x] depends on: #20840
- [x] depends on: #21096 



Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

large-import Automatically added label for PRs with a significant increase in transitive imports ready-to-merge This PR has been sent to bors. t-category-theory Category theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants