Skip to content

test: merge bot fixes#20791

Closed
adomani wants to merge 31 commits intomasterfrom
test/merge_bot_fixes
Closed

test: merge bot fixes#20791
adomani wants to merge 31 commits intomasterfrom
test/merge_bot_fixes

Conversation

@adomani
Copy link
Copy Markdown
Contributor

@adomani adomani commented Jan 16, 2025

A PR accompanying #20789.


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 16, 2025

PR summary 757a4e6a0f

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Data.ENat.Basic 477 476 -1 (-0.21%)
Import changes for all files
Files Import difference
8 files Mathlib.Combinatorics.SimpleGraph.Diam Mathlib.Combinatorics.SimpleGraph.Metric Mathlib.Data.ENat.Basic Mathlib.Data.ENat.BigOperators Mathlib.Data.ENat.Lattice Mathlib.NumberTheory.Padics.PadicVal.Defs Mathlib.Order.Height Mathlib.RingTheory.Multiplicity
-1

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the CI Modifies the continuous integration setup or other automation label Jan 16, 2025
@adomani adomani marked this pull request as ready for review January 16, 2025 09:44
@adomani
Copy link
Copy Markdown
Contributor Author

adomani commented Jan 16, 2025

bot fix style

leanprover-community-mathlib4-bot and others added 2 commits January 16, 2025 09:50
Copy link
Copy Markdown
Contributor Author

@adomani adomani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment came from a review

bot fix style

bot fix style

and I wrote bot fix style twice (or is it 3 times?).

@adomani adomani force-pushed the test/merge_bot_fixes branch from 0fdec63 to 062fb9d Compare January 16, 2025 10:40
Copy link
Copy Markdown
Contributor Author

@adomani adomani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even without the prompt of the bot, I will still say

bot fix style

in a review.

Copy link
Copy Markdown
Contributor Author

@adomani adomani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From review

bot fix style

types: [created, edited]
pull_request_review:
# triggers on a review, whether or not it is accompanied by a comment
types: [submitted]
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From review comment

bot fix style

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The above comment worked, but reviewdog had not posted anything.

Copy link
Copy Markdown
Contributor Author

@adomani adomani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From review

bot fix style

mathlib-bors bot pushed a commit that referenced this pull request Jan 16, 2025
This PR continues the series of merging CI actions that are triggered by `comment`s, `review`s and `review_comment`s.

Specifically, we merge here the 3 `bot fix style` actions into a single one.

#20791 tests that the new action works as intended.
mathlib-bors bot pushed a commit that referenced this pull request Jan 16, 2025
This PR continues the series of merging CI actions that are triggered by `comment`s, `review`s and `review_comment`s.

Specifically, we merge here the 3 `bot fix style` actions into a single one.

#20791 tests that the new action works as intended.
@adomani
Copy link
Copy Markdown
Contributor Author

adomani commented Jan 16, 2025

Thanks for your help in debugging!

@adomani adomani closed this Jan 16, 2025
@YaelDillies YaelDillies deleted the test/merge_bot_fixes branch August 17, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Modifies the continuous integration setup or other automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant