[Merged by Bors] - feat(Order): relate chains to antichains#20756
[Merged by Bors] - feat(Order): relate chains to antichains#20756
Conversation
|
messageFile.md |
vihdzp
left a comment
There was a problem hiding this comment.
I'm surprised we weren't already defining IsAntichain r s as IsChain rᶜ s, I completely agree with the import increase.
|
I do think we should do something about the new imports. I will investigate |
|
Okay, I see many ways to get rid of the import increase, so I think this PR can move forward. maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
|
Thanks 🎉 bors merge |
A set which is a chain and an antichain is subsingleton. As a result, the intersection of a chain and antichain is subsingleton. Useful from the disproof of the Aharoni–Korman conjecture, #20082. I believe the large import here is acceptable, as `IsChain` and `IsAntichain` need to be related to each other somewhere, but there is not much to say about both (as this PR shows). As such, making a third file specifically for these seems unnecessary, and putting these in `Order.Chain` results in a larger import change.
|
Build failed (retrying...): |
A set which is a chain and an antichain is subsingleton. As a result, the intersection of a chain and antichain is subsingleton. Useful from the disproof of the Aharoni–Korman conjecture, #20082. I believe the large import here is acceptable, as `IsChain` and `IsAntichain` need to be related to each other somewhere, but there is not much to say about both (as this PR shows). As such, making a third file specifically for these seems unnecessary, and putting these in `Order.Chain` results in a larger import change.
|
Pull request successfully merged into master. Build succeeded: |
|
There was a question on Zulip about what was the import diff for this PR. As far as I can tell, below is the import diff between and Import changes for all files
|
|
Thanks for this! Interesting to see that this gives an import difference of 15 rather than the import difference of 14 reported by the bot earlier - I suppose this is because of other changes that got merged at the same time? |
|
I do not know where the "extra" import comes from, but I did have to pick manually a reference commit and I chose |
A set which is a chain and an antichain is subsingleton. As a result, the intersection of a chain and antichain is subsingleton.
Useful from the disproof of the Aharoni–Korman conjecture, #20082.
I believe the large import here is acceptable, as
IsChainandIsAntichainneed to be related to each other somewhere, but there is not much to say about both (as this PR shows). As such, making a third file specifically for these seems unnecessary, and putting these inOrder.Chainresults in a larger import change.