Skip to content

[Merged by Bors] - chore(RingTheory/Extension): Simplify algebra instance by using def.#20708

Closed
edegeltje wants to merge 2 commits intomasterfrom
blizzard_inc/replace_algebra_instance
Closed

[Merged by Bors] - chore(RingTheory/Extension): Simplify algebra instance by using def.#20708
edegeltje wants to merge 2 commits intomasterfrom
blizzard_inc/replace_algebra_instance

Conversation

@edegeltje
Copy link
Copy Markdown
Collaborator

As suggested in the conversation around #20518 , the algebra instance has been subsumed by a definition, and this PR makes the replacement.


Open in Gitpod

@edegeltje edegeltje added easy < 20s of review time. See the lifecycle page for guidelines. t-algebra Algebra (groups, rings, fields, etc) labels Jan 13, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 13, 2025

PR summary c1f1dccbba

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Copy Markdown
Contributor

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

bors r+

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Jan 13, 2025
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 13, 2025

Canceled.

@Vierkantor
Copy link
Copy Markdown
Contributor

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 13, 2025

✌️ edegeltje can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Jan 13, 2025
@edegeltje
Copy link
Copy Markdown
Collaborator Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Jan 13, 2025
…20708)

As suggested in the conversation around #20518 , the algebra instance has been subsumed by a definition, and this PR makes the replacement.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 13, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(RingTheory/Extension): Simplify algebra instance by using def. [Merged by Bors] - chore(RingTheory/Extension): Simplify algebra instance by using def. Jan 13, 2025
@mathlib-bors mathlib-bors bot closed this Jan 13, 2025
@mathlib-bors mathlib-bors bot deleted the blizzard_inc/replace_algebra_instance branch January 13, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants