Skip to content

[Merged by Bors] - feat(Data/Finsupp/MonomialOrder) : lexicographic order on Unique#20699

Closed
AntoineChambert-Loir wants to merge 3 commits intomasterfrom
ACL/CombNS-unique
Closed

[Merged by Bors] - feat(Data/Finsupp/MonomialOrder) : lexicographic order on Unique#20699
AntoineChambert-Loir wants to merge 3 commits intomasterfrom
ACL/CombNS-unique

Conversation

@AntoineChambert-Loir
Copy link
Copy Markdown
Collaborator

@AntoineChambert-Loir AntoineChambert-Loir commented Jan 13, 2025 •
edited
Loading

Two lemmas for lexicographic order on aUnique type are added.

Open in Gitpod

@AntoineChambert-Loir AntoineChambert-Loir changed the title refactor(Data/Finsupp/MonomialOrder) : add lemmas for Unique feat(Data/Finsupp/MonomialOrder) : add lemmas for Unique Jan 13, 2025
@AntoineChambert-Loir AntoineChambert-Loir mentioned this pull request Jan 13, 2025
Closed
6 tasks
@github-actions github-actions bot added the t-data Data (lists, quotients, numbers, etc) label Jan 13, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 13, 2025 •
edited
Loading

PR summary f997130061

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ MonomialOrder.lex_le_iff_of_unique
+ MonomialOrder.lex_lt_iff_of_unique
+ lex_le_iff_of_unique
+ lex_lt_iff
+ lex_lt_iff_of_unique
- Finsupp.lex_le_iff
- Finsupp.lex_lt_iff

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@AntoineChambert-Loir AntoineChambert-Loir changed the title feat(Data/Finsupp/MonomialOrder) : add lemmas for Unique feat(Data/Finsupp/MonomialOrder) : add lemmas for lexicographic order on Unique Jan 13, 2025
@AntoineChambert-Loir AntoineChambert-Loir changed the title feat(Data/Finsupp/MonomialOrder) : add lemmas for lexicographic order on Unique feat(Data/Finsupp/MonomialOrder) : lexicographic order on Unique Jan 13, 2025
YaelDillies
YaelDillies reviewed Jan 13, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you expect these to be useful if made simp?

@YaelDillies YaelDillies added the awaiting-author A reviewer has asked the author a question or requested changes. label Jan 13, 2025
vihdzp
vihdzp reviewed Jan 13, 2025
View reviewed changes
@AntoineChambert-Loir
Copy link
Copy Markdown
Collaborator Author

AntoineChambert-Loir commented Jan 14, 2025

Do you expect these to be useful if made simp?

I am not sure. I have no idea, in fact. I tend to prefer the more bundled versions, because mathematically they embody more relevant stuff. For example, I did not tag as simp the two lemmas ahead, MonomialOrder.lex_le_iff and its lt variant.

@AntoineChambert-Loir AntoineChambert-Loir removed the awaiting-author A reviewer has asked the author a question or requested changes. label Jan 14, 2025
vihdzp
vihdzp approved these changes Jan 14, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@vihdzp vihdzp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

@joelriou
Copy link
Copy Markdown
Contributor

joelriou commented Jan 30, 2025

Thanks!

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Jan 30, 2025
mathlib-bors bot pushed a commit that referenced this pull request Jan 30, 2025
@AntoineChambert-Loir
feat(Data/Finsupp/MonomialOrder) : lexicographic order on Unique (#…
f17018b 
…20699)

Two lemmas for lexicographic order on a`Unique` type are added.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 30, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Data/Finsupp/MonomialOrder) : lexicographic order on Unique [Merged by Bors] - feat(Data/Finsupp/MonomialOrder) : lexicographic order on Unique Jan 30, 2025
@mathlib-bors mathlib-bors bot closed this Jan 30, 2025
@mathlib-bors mathlib-bors bot deleted the ACL/CombNS-unique branch January 30, 2025 13:06
jt496 pushed a commit that referenced this pull request Feb 3, 2025
@AntoineChambert-Loir @jt496
feat(Data/Finsupp/MonomialOrder) : lexicographic order on Unique (#…
40c1929 
…20699)

Two lemmas for lexicographic order on a`Unique` type are added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YaelDillies YaelDillies YaelDillies left review comments

+1 more reviewer

@vihdzp vihdzp vihdzp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready-to-merge This PR has been sent to bors. t-data Data (lists, quotients, numbers, etc)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AntoineChambert-Loir @joelriou @YaelDillies @vihdzp