Skip to content

[Merged by Bors] - chore(RingTheory/MvPolynomial/WeightedHomogeneous): golf the proof a lemma#20697

Closed
AntoineChambert-Loir wants to merge 2 commits intomasterfrom
ACL/CombNS-golf
Closed

[Merged by Bors] - chore(RingTheory/MvPolynomial/WeightedHomogeneous): golf the proof a lemma#20697
AntoineChambert-Loir wants to merge 2 commits intomasterfrom
ACL/CombNS-golf

Conversation

@AntoineChambert-Loir
Copy link
Copy Markdown
Collaborator

This simplifies a proof.


Open in Gitpod

@AntoineChambert-Loir AntoineChambert-Loir changed the title chose(RingTheory/MvPolynomial/WeightedHomogeneous): golf the proof a lemma chore(RingTheory/MvPolynomial/WeightedHomogeneous): golf the proof a lemma Jan 13, 2025
@AntoineChambert-Loir AntoineChambert-Loir added awaiting-author A reviewer has asked the author a question or requested changes. t-algebra Algebra (groups, rings, fields, etc) labels Jan 13, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 13, 2025

PR summary cdbd6c9021

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@AntoineChambert-Loir AntoineChambert-Loir removed the awaiting-author A reviewer has asked the author a question or requested changes. label Jan 13, 2025
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for atomising the PR!

maintainer delegate

(Function.support fun m => weightedHomogeneousComponent w m φ) ⊆
(fun d => weight w d) '' φ.support by
exact Finite.subset ((fun d : σ →₀ ℕ => (weight w) d) '' ↑(support φ)).toFinite this
apply Finite.subset ((fun d : σ →₀ ℕ => (weight w) d) '' (φ.support : Set (σ →₀ ℕ))).toFinite
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
apply Finite.subset ((fun d : σ →₀ ℕ => (weight w) d) '' (φ.support : Set (σ →₀ ℕ))).toFinite
apply ((fun d : σ →₀ ℕ => (weight w) d) '' (φ.support : Set (σ →₀ ℕ))).toFinite.subset

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jan 13, 2025
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 13, 2025

✌️ AntoineChambert-Loir can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Jan 13, 2025
@AntoineChambert-Loir
Copy link
Copy Markdown
Collaborator Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Jan 14, 2025
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 14, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(RingTheory/MvPolynomial/WeightedHomogeneous): golf the proof a lemma [Merged by Bors] - chore(RingTheory/MvPolynomial/WeightedHomogeneous): golf the proof a lemma Jan 14, 2025
@mathlib-bors mathlib-bors bot closed this Jan 14, 2025
@mathlib-bors mathlib-bors bot deleted the ACL/CombNS-golf branch January 14, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. t-algebra Algebra (groups, rings, fields, etc)

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants