Skip to content

[Merged by Bors] - chore(WittVector): document more notation#20683

Closed
grunweg wants to merge 2 commits intomasterfrom
MR-inherit-doc-isocrystal
Closed

[Merged by Bors] - chore(WittVector): document more notation#20683
grunweg wants to merge 2 commits intomasterfrom
MR-inherit-doc-isocrystal

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Jan 12, 2025


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 12, 2025

PR summary 5bce9e280d

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (7.00, 0.01)
Current number Change Type
666 -7 documentation nolint entries

Current commit 5bce9e280d
Reference commit 85ca5b28ae

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Jan 12, 2025
@grunweg grunweg force-pushed the MR-inherit-doc-isocrystal branch from 6f0636b to 56f9ce4 Compare January 12, 2025 11:31
@grunweg grunweg requested review from Ruben-VandeVelde, eric-wieser and jcommelin and removed request for Ruben-VandeVelde and eric-wieser January 12, 2025 11:41
@grunweg grunweg added the documentation Improvements or additions to documentation label Jan 12, 2025
Copy link
Copy Markdown
Contributor

@mattrobball mattrobball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor style question. Otherwise, looks good and thanks!

Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 13, 2025

✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Jan 13, 2025
Co-authored-by: Johan Commelin <johan@commelin.net>
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Jan 13, 2025

Thanks!
bors merge

mathlib-bors bot pushed a commit that referenced this pull request Jan 13, 2025
Co-authored-by: grunweg <rothgami@math.hu-berlin.de>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 13, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(WittVector): document more notation [Merged by Bors] - chore(WittVector): document more notation Jan 13, 2025
@mathlib-bors mathlib-bors bot closed this Jan 13, 2025
@mathlib-bors mathlib-bors bot deleted the MR-inherit-doc-isocrystal branch January 13, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). documentation Improvements or additions to documentation t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants