Skip to content

[Merged by Bors] - feat(CategoryTheory): weak factorization systems#20680

Closed
joelriou wants to merge 14 commits intomasterfrom
jriou-wfs-0
Closed

[Merged by Bors] - feat(CategoryTheory): weak factorization systems#20680
joelriou wants to merge 14 commits intomasterfrom
jriou-wfs-0

Conversation

@joelriou
Copy link
Copy Markdown
Contributor

@joelriou joelriou commented Jan 12, 2025 •
edited
Loading

@joelriou joelriou added the t-category-theory Category theory label Jan 12, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 12, 2025 •
edited
Loading

PR summary 6405000a04

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.CategoryTheory.MorphismProperty.WeakFactorizationSystem (new file) 643

Declarations diff

+ IsWeakFactorizationSystem
+ hasLiftingProperty_of_wfs
+ llp_eq_of_wfs
+ mk'
+ rlp_eq_of_wfs

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@joelriou @github-actions
Update Mathlib.lean
296c447 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@joelriou joelriou mentioned this pull request Jan 12, 2025
Closed
3 tasks
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Jan 12, 2025
@joelriou joelriou mentioned this pull request Jan 12, 2025
Closed
3 tasks
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 22, 2025
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 23, 2025
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 9, 2025
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Feb 12, 2025
@mathlib4-dependent-issues-bot
Copy link
Copy Markdown
Collaborator

mathlib4-dependent-issues-bot commented Feb 12, 2025

This PR/issue depends on:

@joelriou joelriou added the WIP Work in progress label Feb 12, 2025
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 12, 2025
@joelriou joelriou removed the WIP Work in progress label Feb 12, 2025
callesonne
callesonne approved these changes Mar 2, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@callesonne callesonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very straightforward, LGTM!

@joelriou @callesonne
Update Mathlib/CategoryTheory/MorphismProperty/WeakFactorizationSyste…
dafd539 
…m.lean

Co-authored-by: Calle Sönne <calle.sonne@gmail.com>
adamtopaz
adamtopaz reviewed Apr 5, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@adamtopaz adamtopaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Apr 5, 2025
mathlib-bors bot pushed a commit that referenced this pull request Apr 5, 2025
@joelriou
feat(CategoryTheory): weak factorization systems (#20680)
7684419 
Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 5, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(CategoryTheory): weak factorization systems [Merged by Bors] - feat(CategoryTheory): weak factorization systems Apr 5, 2025
@mathlib-bors mathlib-bors bot closed this Apr 5, 2025
@mathlib-bors mathlib-bors bot deleted the jriou-wfs-0 branch April 5, 2025 22:08
@alreadydone alreadydone mentioned this pull request Apr 5, 2025
Closed
2 tasks
tannerduve pushed a commit that referenced this pull request May 13, 2025
@joelriou @tannerduve
feat(CategoryTheory): weak factorization systems (#20680)
39ae0ab 
Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamtopaz adamtopaz adamtopaz left review comments

+1 more reviewer

@callesonne callesonne callesonne approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready-to-merge This PR has been sent to bors. t-category-theory Category theory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@joelriou @mathlib4-dependent-issues-bot @adamtopaz @callesonne @leanprover-community-bot-assistant