Skip to content

[Merged by Bors] - chore(1000.yaml): re-enable comments, add more entries#20554

Closed
grunweg wants to merge 22 commits intomasterfrom
MR-1000-tweaks
Closed

[Merged by Bors] - chore(1000.yaml): re-enable comments, add more entries#20554
grunweg wants to merge 22 commits intomasterfrom
MR-1000-tweaks

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Jan 7, 2025


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 7, 2025

PR summary 54b4119ac3

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Jan 7, 2025
@grunweg grunweg changed the title chore(1000.yaml): re-enable comments, small additions and tweaks chore(1000.yaml): re-enable comments, add more entries Jan 8, 2025
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Jan 9, 2025
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 9, 2025

✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Jan 9, 2025
grunweg and others added 2 commits January 9, 2025 18:11
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Jan 9, 2025

Your suggested fix was not quite right, but now it works. Thanks for the quick review!
bors merge

mathlib-bors bot pushed a commit that referenced this pull request Jan 9, 2025
Co-authored-by: Michael Rothgang <rothgang@math.uni-bonn.de>
Co-authored-by: grunweg <rothgami@math.hu-berlin.de>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 9, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(1000.yaml): re-enable comments, add more entries [Merged by Bors] - chore(1000.yaml): re-enable comments, add more entries Jan 9, 2025
@mathlib-bors mathlib-bors bot closed this Jan 9, 2025
@mathlib-bors mathlib-bors bot deleted the MR-1000-tweaks branch January 9, 2025 17:30
grunweg added a commit that referenced this pull request Jan 11, 2025
Co-authored-by: Michael Rothgang <rothgang@math.uni-bonn.de>
Co-authored-by: grunweg <rothgami@math.hu-berlin.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants