Skip to content

[Merged by Bors] - chore: remove >9 month old deprecations#20505

Closed
kim-em wants to merge 1 commit intomasterfrom
rm_deprecations_2025-01
Closed

[Merged by Bors] - chore: remove >9 month old deprecations#20505
kim-em wants to merge 1 commit intomasterfrom
rm_deprecations_2025-01

Conversation

@kim-em
Copy link
Copy Markdown
Contributor

@kim-em kim-em commented Jan 6, 2025

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 6, 2025

PR summary bcc4b3c17f

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

- Absorbent.zero_mem'
- AddEquiv.lpBcf
- AlgEquiv.lpBcf
- Balanced.mem_smul_iff
- Basis.exists_op_nnnorm_le
- Basis.exists_op_norm_le
- Basis.op_nnnorm_le
- Basis.op_norm_le
- CharP.pow_prime_pow_mul_eq_one_iff
- ClosedIciTopology.isClosed_ge'
- ClosedIicTopology.isClosed_le'
- ContinuousLinearMap.op_norm_bound_of_ball_bound
- DiscreteTopology.secondCountableTopology_of_encodable
- FiniteDimensional.finiteDimensional_of_fact_finrank_eq_two
- Function.LeftInverse.closed_range
- GCDMonoid.irreducible_iff_prime
- GCDMonoid.prime_of_irreducible
- HasFTaylorSeriesUpToOn.eq_ftaylor_series_of_uniqueDiffOn
- HasSum.nonneg_add_neg
- HasSum.pos_add_zero_add_neg
- HasSum.sum_nat_of_sum_int
- Irreducible.nat_degree_le_two
- IsAddCyclic.card_orderOf_eq_totient
- IsAddCyclic.card_pow_eq_one_le
- IsAddUnit.add_sub_cancel'
- IsCompact.nonempty_iInter_of_directed_nonempty_compact_closed
- IsCompact.nonempty_iInter_of_sequence_nonempty_compact_closed
- IsOfFinAddOrder.powers_eq_image_range_orderOf
- IsOpenImmersion.open_range
- IsPrefix.filter_map
- IsSubmonoid.power_subset
- IsUnit.mul_div_cancel'
- LowerSemicontinuous.IsClosed_epigraph
- Nonempty.bex
- Prod.add_orderOf
- QuotientKerAlgEquivOfRightInverseSymm.apply
- Real.atBot_le_cocompact
- Real.atTop_le_cocompact
- Real.cocompact_eq
- RegularSpace.ofBasis
- RegularSpace.ofExistsMemNhdsIsClosedSubset
- RegularSpace.ofLift'_closure
- RingEquiv.lpBcf
- SeqCompact.lebesgue_number_lemma_of_metric
- StrictAntiOn_of_hasDerivWithinAt_pos
- StrictMonoOn_of_hasDerivWithinAt_pos
- TwoUniqueProds.mulHom_image_iff
- TwoUniqueProds.mulHom_image_of_injective
- TwoUniqueSums.addHom_image_iff
- TwoUniqueSums.addHom_image_of_injective
- UniformSpace.ofNhdsEqComap
- UniqueFactorizationMonoid.dvd_pow_iff_dvd_of_squarefree
- UniqueProds.mulHom_image_iff
- UniqueProds.mulHom_image_of_injective
- UniqueSums.addHom_image_iff
- UniqueSums.addHom_image_of_injective
- _root_.AddAction.orbit_zmultiples_equiv_symm_apply
- _root_.CategoryTheory.cofiltered_of_hasFiniteLimits
- _root_.MvPolynomial.C_mul_X
- _root_.fourier_transform_gaussian
- _root_.fourier_transform_gaussian_pi'
- aEMeasurable_coe_nnreal_real_iff
- abv_sum_le_sum_abv
- addHaarScalarFactor_eq_one_of_isProbabilityMeasure
- addHaarScalarFactor_pos_of_isOpenPosMeasure
- add_def''
- add_nat_le_add_nat_iff_of_lt_aleph_0
- add_one_le_add_one_iff_of_lt_aleph_0
- add_orderOf_fst_dvd_add_orderOf
- add_sub_cancel'
- add_sub_cancel'_right
- angle_eq_left
- angle_eq_of_ne
- angle_eq_right
- associates_irreducible_iff_prime
- atBot_le_nhds_bot
- atTop_le_nhds_top
- balanced_convexHull_of_balanced
- balanced_zero_union_interior
- ball_cond_comm
- ball_empty_iff
- ball_image_iff
- ball_insert_iff
- ball_mem_comm
- ball_of_forall
- bex_cons
- bex_image_iff
- bex_imp
- bex_insert_iff
- bex_of_exists
- bijective_symm
- bind_ret_eq_map
- card_disjoint_union
- card_union_eq
- cast_coe_int
- cast_coe_nat
- cast_le_cast
- chromaticNumber_le_card
- closed_range_toBCF
- cocompact_eq
- coeFn_abs
- coeFn_sup
- coe_eq
- coe_nat_zsmul
- commutative_of_add_cyclic_center_quotient
- compactOpen_eq_sInf_induced
- continuous_curry'
- continuous_uncurry_left
- continuous_uncurry_right
- curry'
- dist_le_op_norm
- divInt_neg_den
- divInt_neg_one_one
- divInt_zero_one
- div_le_div_of_le
- div_le_div_of_le_left
- div_le_div_of_le_of_nonneg
- div_lt_div_of_lt
- div_lt_div_of_lt_left
- div_mul_cancel'
- div_mul_cancel''
- div_mul_cancel'''
- div_mul_left
- div_mul_right
- dvd_iff_modByMonic_eq_zero
- eq_iff_veq
- eq_of_dist_eq_zero
- eq_of_nhds_eq_nhds
- eq_of_veq
- exists_lt_apply_of_lt_op_nnnorm
- exists_lt_apply_of_lt_op_norm
- exists_mul_lt_apply_of_lt_op_nnnorm
- exists_mul_lt_of_lt_op_norm
- exists_of_bex
- exists_pow_eq_one_of_zpow_eq_one
- exists_range_iff'
- factors_0
- finiteDimensional
- finiteDimensional_of_exists_primitive_element
- finiteDimensional_of_finite_intermediateField
- finiteDimensional_of_isCompact_closedBall
- finiteDimensional_of_isCompact_closedBall₀
- finiteDimensional_of_locallyCompactSpace
- finiteDimensional_of_rank_eq_nat
- finiteDimensional_of_rank_eq_one
- finiteDimensional_of_rank_eq_zero
- forall_of_ball
- forall_range_iff
- fourierIntegral_def
- fourierIntegral_eq_integral_exp_smul
- fourier_integral_convergent_iff
- haarScalarFactor_eq_one_of_isProbabilityMeasure
- haarScalarFactor_pos_of_isOpenPosMeasure
- hasColimit_of_closed_under_colimits
- hasColimitsOfShape_of_closed_under_colimits
- hasFiniteIntegral_of_fintype
- hasLimit_of_closed_under_limits
- int_cast_abs
- integrableOn_peak_smul_of_integrableOn_of_continuousWithinAt
- integrable_of_fintype
- involutive_symm
- irreducible_iff_prime
- isAddCyclic_of_card_pow_eq_one_le
- isAddCyclic_of_orderOf_eq_card
- isAddHaarMeasure_eq_smul
- isColimitConeOp
- isColimitConeUnop
- isConnected_zigzag
- isGδ_biInter
- isGδ_biInter_of_isOpen
- isGδ_biUnion
- isGδ_compl_singleton
- isGδ_empty
- isGδ_iInter_of_isOpen
- isGδ_irrational
- isGδ_sInter
- isGδ_setOf_continuousAt
- isGδ_setOf_liouville
- isGδ_singleton
- isGδ_univ
- isHaarMeasure_eq_smul
- isLimitCoconeOp
- isLimitCoconeUnop
- isPrimal_iff
- isSeparable_of_separableSpace
- isSeparable_of_separableSpace_subtype
- is_semisimple_iff_top_eq_sSup_simples
- is_semisimple_of_sSup_simples_eq_top
- l2_op_nnnorm_conjTranspose
- l2_op_nnnorm_conjTranspose_mul_self
- l2_op_nnnorm_def
- l2_op_nnnorm_mul
- l2_op_nnnorm_mulVec
- l2_op_norm_conjTranspose
- l2_op_norm_conjTranspose_mul_self
- l2_op_norm_def
- l2_op_norm_mul
- l2_op_norm_mulVec
- lTensor_inj_iff_rTensor_inj
- le_mul_prod_of_le_op_norm_of_le
- le_of_op_nnnorm_le
- le_of_op_norm_le_of_le
- le_of_op_norm₂_le_of_le
- le_op_norm_mul_pow_card_of_le
- le_op_norm_mul_pow_of_le
- le_op_norm_mul_prod_of_le
- le_op_norm_of_le
- le_op_norm₂
- le_sqrt_iff
- linfty_op_nnnorm_col
- linfty_op_nnnorm_def
- linfty_op_nnnorm_diagonal
- linfty_op_nnnorm_eq_op_nnnorm
- linfty_op_nnnorm_mul
- linfty_op_nnnorm_mulVec
- linfty_op_nnnorm_row
- linfty_op_nnnorm_toMatrix
- linfty_op_norm_col
- linfty_op_norm_def
- linfty_op_norm_diagonal
- linfty_op_norm_eq_op_norm
- linfty_op_norm_mul
- linfty_op_norm_mulVec
- linfty_op_norm_row
- linfty_op_norm_toMatrix
- lowerSemicontinuous_iff_IsClosed_epigraph
- lpBcfₗᵢ
- map_ret_sublist_sublists
- max_power_factor
- mem_coclosedCompact
- mem_coclosed_compact'
- mem_image_elim
- mem_image_elim_on
- mem_image_iff_bex
- mem_split
- mk_le_mk_iff_dvd_iff
- mono'
- mul_div_cancel'
- mul_div_cancel''
- mul_div_cancel'''
- mul_div_cancel'_right
- natCast_eq_ofNat
- nhdsAdjoint_nhds
- nhdsAdjoint_nhds_of_ne
- nhds_compactOpen_eq_sInf_nhds_induced
- nndist_le_op_nnnorm
- nonempty_hom_of_connected_groupoid
- norm_setToSimpleFunc_le_sum_op_norm
- not_bex_nil
- num_nonneg_iff_zero_le
- num_pos_iff_pos
- ofFintype
- one_lt_card_iff_nontrivial_coe
- op_nnnorm_comp_le
- op_nnnorm_eq_of_bounds
- op_nnnorm_le_bound
- op_nnnorm_le_bound'
- op_nnnorm_le_of_lipschitz
- op_nnnorm_le_of_unit_nnnorm
- op_nnnorm_mul
- op_nnnorm_mul_apply
- op_nnnorm_mul_flip_apply
- op_norm_comp_le
- op_norm_comp_linearIsometryEquiv
- op_norm_eq_of_bounds
- op_norm_ext
- op_norm_extend_le
- op_norm_flip
- op_norm_le_bound'
- op_norm_le_bound₂
- op_norm_le_of_ball
- op_norm_le_of_lipschitz
- op_norm_le_of_nhds_zero
- op_norm_le_of_shell
- op_norm_le_of_shell'
- op_norm_le_of_unit_norm
- op_norm_lsmul
- op_norm_lsmul_apply_le
- op_norm_lsmul_le
- op_norm_mul
- op_norm_mulLeftRight_apply_apply_le
- op_norm_mulLeftRight_apply_le
- op_norm_mulLeftRight_le
- op_norm_mul_apply
- op_norm_mul_apply_le
- op_norm_mul_flip_apply
- op_norm_mul_le
- op_norm_pi
- op_norm_subsingleton
- open_map_of_strict_deriv
- open_map_of_strict_fderiv_equiv
- pairwise_map'
- preserves_injective_linearMap
- quotientKerAlgEquivOfRightInverse.apply
- ring_sep_quot
- ring_sep_rel
- root_.fourier_transform_gaussian_pi
- set_smul_mono_right
- small_of_countable
- small_of_fintype
- smul_iInf_le
- smul_inf_le
- smul_mono_right
- span_eq_top_of_linearIndependent_of_card_eq_finrank
- sqrt_eq_iff_sq_eq
- sqrt_le_iff
- sqrt_le_sqrt_iff
- sqrt_lt_sqrt_iff
- strictAnti_of_hasDerivAt_pos
- stronglyMeasurable_of_fintype
- stronglyMeasurable_of_isEmpty
- sub_add_cancel'
- sub_add_cancel''
- sub_def''
- summable_int_of_summable_nat
- t2Space
- tendsto_setIntegral_peak_smul_of_integrableOn_of_continuousWithinAt
- tendsto_setIntegral_peak_smul_of_integrableOn_of_continuousWithinAt_aux
- toNat_add_of_lt_aleph0
- toNat_cast
- toNat_finset_prod
- toNat_le_of_le_of_lt_aleph0
- toNat_lt_of_lt_of_lt_aleph0
- toPartENat_cast
- toPartENat_eq_top_iff_le_aleph0
- toSpecFromSpec
- to_digits_core_length
- to_digits_core_lens_eq:=
- to_digits_core_lens_eq_aux:=
- ufm_of_gcd_of_wfDvdMonoid
- veq_of_eq
- zeta_LSeriesSummable_iff_one_lt_re
- zpow_coe_nat
-- inter_distrib_left
-- inter_distrib_right
-- isLeast_op_nnnorm
-- isLeast_op_norm
-- le_of_op_norm_le
-- le_op_nnnorm
-- le_op_norm
-- op_nnnorm_le_iff
-- op_nnnorm_prod
-- op_norm_add_le
-- op_norm_le_bound
-- op_norm_le_iff
-- op_norm_neg
-- op_norm_nonneg
-- op_norm_prod
-- op_norm_smul_le
-- op_norm_zero
-- op_norm_zero_iff
-- ratio_le_op_norm
-- union_distrib_left
-- union_distrib_right
-- unit_le_op_norm
-- ⟨_,
--- closed_range

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (1.11, 0.01)
Current number Change Type
4823 -1 porting notes
93 -1 disabled deprecation lints
3101 -5 total LoC in Deprecated files

Current commit bcc4b3c17f
Reference commit 95cdc7a6ab

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@eric-wieser
Copy link
Copy Markdown
Member

What's our strategy to avoid:

  • Someone makes a PR that sits open for 9 months, with deprecations
  • It finally gets merged
  • Coincidentally, we immediately embark on a deprecation-cleaning pass
  • Only after that cleaning concludes do we hit a v4.x.y tag

(Which is undesirable because downstream users hopping between major releases would never see the deprecation)

Is the answer "ask to update the dates (if they're more than 2 months old) before merging in step 2"?

@kim-em
Copy link
Copy Markdown
Contributor Author

kim-em commented Jan 6, 2025

Is the answer "ask to update the dates (if they're more than 2 months old) before merging in step 2"?

This seems reasonable.

(Also --- let's not have PRs that take 9 months to merge! :-)

Copy link
Copy Markdown
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

Thanks!

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Jan 6, 2025
mathlib-bors bot pushed a commit that referenced this pull request Jan 6, 2025
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 6, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: remove >9 month old deprecations [Merged by Bors] - chore: remove >9 month old deprecations Jan 6, 2025
@mathlib-bors mathlib-bors bot closed this Jan 6, 2025
@mathlib-bors mathlib-bors bot deleted the rm_deprecations_2025-01 branch January 6, 2025 10:57
Julian added a commit that referenced this pull request Jan 6, 2025
* origin/master: (189 commits)
  chore(Algebra): make more names consistent (#20449)
  feat: Polynomial FLT (#18882)
  feat: A disjoint union is finite iff all sets are finite, and all but finitely many are empty (#20457)
  fix: linkfix in 100.yaml (#20517)
  feat(1000): fill in more entries (#20470)
  feat(Combinatorics/SimpleGraph/Walk): add `penultimate` and `snd` (#16769)
  feat(ContinuousMultilinearMap): add lemmas about `.prod` (#20462)
  feat(RingTheory): classification of etale algebras over fields (#20324)
  fix: Allow multiple builds on staging branch (#20515)
  feat(CategoryTheory/Shift/Adjunction): properties of `Adjunction.CommShift` (#20337)
  chore(Data/Multiset/Basic): move the `sub`, `union`, `inter` sections lower (#19863)
  chore(Topology/UniformSpace/Completion): make coe' argument implicit (#20514)
  refactor(Algebra/Category/Grp/Colimits): change the construction of colimits in `AddCommGrp` (#20474)
  feat(Topology/Algebra/InfiniteSum/NatInt): Add pnat lems (#16544)
  chore(RingTheory/Finiteness): rename Module.Finite.out (#20506)
  refactor(CategoryTheory/Limits/Preserves/Ulift): simplify the proof that the universe lifting functor for types preserves all colimits (#20508)
  feat(CategoryTheory): products in the category of Ind-objects (#20507)
  chore: remove >9 month old deprecations (#20505)
  chore(FieldTheory/Galois): small cleanup (#20217)
  chore(LinearIndependent): generalize to semirings (#20480)
  chore(NumberTheory/NumberField/AdeleRing): refactor adele rings (#20500)
  chore: replace `aesop` with `simp` where possible (#20483)
  chore(1000): remove nonexistent fields (#20493)
  chore(CategoryTheory/Adjunction.Basic, CategoryTheory/Equivalence): change definition of `Adjunction.comp` and `Equivalence.trans` (#20490)
  feat(Asymptotics): add `Asymptotics.*.*Prod` lemmas (#20458)
  feat: a conditional kernel is almost everywhere a probability measure (#20430)
  feat: if `f` is a measurable group hom, then every point has a neighborhood `s` such that `f '' s` is bounded (#20304)
  feat: `Ico`, `Ioc`, and `Ioo` are not closed or compact (#20479)
  chore: drop redundant hypothesis in `Module.Dual.eq_of_preReflection_mapsTo` (#20492)
  feat(FaaDiBruno): derive `DecidableEq` (#20482)
  chore(SetTheory/Ordinal/Basic): `{x // x < y}` → `Iio y` (#20413)
  chore: generalize `FormalMultilinearSeries.ofScalars_norm` to `Seminormed` (#20351)
  chore(MvPolynomial/Localization): golf using TensorProduct (#20309)
  chore(Combinatorics/Enumerative/Partition): auto-derive DecidableEq (#20277)
  chore(CategoryTheory): make relevant parameters explicit in `Arrow.homMk`. (#20259)
  feat: add `IsStarNormal (↑x⁻¹ : R)` instance for `x : Rˣ` (#20091)
  fix: Stop cancelling builds of master (#20435)
  chore: update Mathlib dependencies 2025-01-05 (#20485)
  feat(SetTheory/Cardinal/Arithmetic): miscellaneous cardinality lemmas (#18933)
  chore: bump toolchain to v4.16.0-rc1, and merge bump/v4.16.0 (#20464)
  chore: bot validates lean-toolchain on bump/v4.X.0 branches (#20478)
  feat: shorthand lemmas for the L1 norm (#20383)
  chore: remove unnecessary adaptation notes (#20467)
  chore(Algebra/Category/MonCat/Colimits): remove smallness condition (#20473)
  chore(SetTheory/Ordinal/Arithmetic): `IsLeftCancelAdd Ordinal` (#19888)
  feat(Algebra): more on `OrthogonalIdempotents` (#18195)
  feat(Radical): `(radical a).natDegree ≤ a.natDegree` (#20468)
  feat(Polynomial): `(a^n)' = 0` iff `a' = 0` when `n` doesn't divide the characteristic (#20190)
  feat(Algebra/Lie): add Lie's theorem (#13480)
  chore(RingTheory/Generators): make algebra instance a def (#14265)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants