[Merged by Bors] - feat(Combinatorics/Nullstellensatz): Alon's combinatorial Nullstellensatz#20495
Closed
AntoineChambert-Loir wants to merge 168 commits intomasterfrom
Closed
[Merged by Bors] - feat(Combinatorics/Nullstellensatz): Alon's combinatorial Nullstellensatz#20495AntoineChambert-Loir wants to merge 168 commits intomasterfrom
AntoineChambert-Loir wants to merge 168 commits intomasterfrom
Conversation
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
YaelDillies
approved these changes
Mar 4, 2025
Contributor
YaelDillies
left a comment
There was a problem hiding this comment.
Looks all good to me. I'll let @b-mehta do the final call.
Contributor
|
LGTM since Bhavik is seemingly unavailable maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
b-mehta
approved these changes
Apr 6, 2025
Contributor
b-mehta
left a comment
There was a problem hiding this comment.
This looks very nice, thank you! And my sincerest apologies for the delay.
bors d+
| f.sum_option_index _ (fun _ => zero_smul _ _) fun _ _ _ => add_smul _ _ _ | ||
|
|
||
| theorem eq_option_embedding_update_none_iff [Zero M] {n : Option α →₀ M} {m : α →₀ M} {i : M} : | ||
| (n = (embDomain Embedding.some m).update none i) ↔ |
Contributor
There was a problem hiding this comment.
Suggested change
| (n = (embDomain Embedding.some m).update none i) ↔ | |
| n = (embDomain Embedding.some m).update none i ↔ |
| ext m | ||
| simp only [coeff_zero, optionEquivLeft_coeff_coeff] | ||
| set n := (embDomain Function.Embedding.some m).update none d with hn | ||
| -- set n := embDomain Function.Embedding.some m + Finsupp.single none d with hn |
Contributor
There was a problem hiding this comment.
Suggested change
| -- set n := embDomain Function.Embedding.some m + Finsupp.single none d with hn |
Comment on lines
+209
to
+211
| ∃ (h : σ →₀ MvPolynomial σ R) | ||
| (_ : ∀ i, ((∏ s ∈ S i, (X i - C s)) * h i).totalDegree ≤ f.totalDegree), | ||
| f = linearCombination (MvPolynomial σ R) (fun i ↦ ∏ r ∈ S i, (X i - C r)) h := by |
Contributor
There was a problem hiding this comment.
Perhaps I'm missing something, but it looks like this should be written as ∃ (h : σ →₀ MvPolynomial σ R), then the conjunction of the two statements, rather than a double-exists? That is, the rhs of exists_prop rather than the lhs.
Comment on lines
+229
to
+230
| · rw [← hj] | ||
| exact h' |
Contributor
There was a problem hiding this comment.
Suggested change
| · rw [← hj] | |
| exact h' | |
| · rwa [← hj] |
optional and untested, but it appears cleaner here!
| (f : MvPolynomial σ R) | ||
| (t : σ →₀ ℕ) (ht : f.coeff t ≠ 0) (ht' : f.totalDegree = t.degree) | ||
| (S : σ → Finset R) (htS : ∀ i, t i < #(S i)) : | ||
| ∃ (s : σ → R) (_ : ∀ i, s i ∈ S i), eval s f ≠ 0 := by |
Contributor
|
✌️ AntoineChambert-Loir can now approve this pull request. To approve and merge a pull request, simply reply with |
Collaborator
Author
|
bors r+
Le 6 avril 2025 21:29:20 GMT+02:00, "mathlib-bors[bot]" ***@***.***> a écrit :
…mathlib-bors[bot] left a comment (leanprover-community/mathlib4#20495)
:v: AntoineChambert-Loir can now approve this pull request. To approve and merge a pull request, simply reply with `bors r+`. More detailed instructions are available [here](https://bors.tech/documentation/getting-started/#reviewing-pull-requests).
--
Reply to this email directly or view it on GitHub:
#20495 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 6, 2025
…satz (#20495) This is a formalization of Alon's Combinatorial Nullstellensatz. Meanwhile, prove several results * a multivariate polynomial that vanishes on a too large product set vanishes identically Probably, this file should belong to the `RingTheory.MvPolynomial` hierarchy.
Contributor
|
Build failed (retrying...): |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 6, 2025
…satz (#20495) This is a formalization of Alon's Combinatorial Nullstellensatz. Meanwhile, prove several results * a multivariate polynomial that vanishes on a too large product set vanishes identically Probably, this file should belong to the `RingTheory.MvPolynomial` hierarchy.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
tannerduve
pushed a commit
that referenced
this pull request
May 13, 2025
…satz (#20495) This is a formalization of Alon's Combinatorial Nullstellensatz. Meanwhile, prove several results * a multivariate polynomial that vanishes on a too large product set vanishes identically Probably, this file should belong to the `RingTheory.MvPolynomial` hierarchy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a formalization of Alon's Combinatorial Nullstellensatz.
Meanwhile, prove several results
Probably, this file should belong to the
RingTheory.MvPolynomialhierarchy.