[Merged by Bors] - fix: avoid using custom parser combinators#20355
Closed
eric-wieser wants to merge 2 commits intomasterfrom
Closed
[Merged by Bors] - fix: avoid using custom parser combinators#20355eric-wieser wants to merge 2 commits intomasterfrom
eric-wieser wants to merge 2 commits intomasterfrom
Conversation
These are not supported unless `enableInitializersExecution` is called, and various downstream scripts do not call this. https://leanprover.zulipchat.com/#narrow/channel/270676-lean4/topic/lean4checker.20failure/near/486191171 has some context for the underlying issue, which seems to be that Lean tries to finalize environment extensions even if initializers are disabled, leading to crashes if those extensions (such as the parser alias table) expect initializers to have run.
PR summary ed180cd79fImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
Contributor
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 3, 2025
These are not supported unless `enableInitializersExecution` is called, and various downstream scripts do not call this. https://leanprover.zulipchat.com/#narrow/channel/270676-lean4/topic/lean4checker.20failure/near/486191171 has some context for the underlying issue, which seems to be that Lean tries to finalize environment extensions even if initializers are disabled, leading to crashes if those extensions (such as the parser alias table) expect initializers to have run. To prove this works, this removes `Lean.enableInitializersExecution` from the script to check the yaml files. This is what we will want to do anyway after leanprover/lean4#6325 lands, as this script should not need to run any extensions.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 10, 2025
We provide macros for the following notations: - `⦋m⦌ₙ` denotes the `m`-dimensional simplex in the `n`-truncated simplex category. - `X _⦋m⦌ₙ` denotes the `m`-th term of an `n`-truncated simplicial object `X`. - `X ^⦋m⦌ₙ` denotes the `m`-th term of an `n`-truncated cosimplicial object `X`. For all of these notations, the truncation proof `p : m ≤ n` can also be provided using the syntax `⦋m, p⦌ₙ`, `X _⦋m, p⦌ₙ`, and `X ^⦋m, p⦌ₙ`, respectively. These notations generalize those already in use in `HomotopyCat.lean` and `Coskeletal.lean`. Delaborators for these notations are added in #20719. See #17732 and #20355 to understand the reason for the use of `subscriptTerm`. Co-authored-by: gio256 <gio256@protonmail.com>
tukamilano
pushed a commit
that referenced
this pull request
Mar 20, 2025
We provide macros for the following notations: - `⦋m⦌ₙ` denotes the `m`-dimensional simplex in the `n`-truncated simplex category. - `X _⦋m⦌ₙ` denotes the `m`-th term of an `n`-truncated simplicial object `X`. - `X ^⦋m⦌ₙ` denotes the `m`-th term of an `n`-truncated cosimplicial object `X`. For all of these notations, the truncation proof `p : m ≤ n` can also be provided using the syntax `⦋m, p⦌ₙ`, `X _⦋m, p⦌ₙ`, and `X ^⦋m, p⦌ₙ`, respectively. These notations generalize those already in use in `HomotopyCat.lean` and `Coskeletal.lean`. Delaborators for these notations are added in #20719. See #17732 and #20355 to understand the reason for the use of `subscriptTerm`. Co-authored-by: gio256 <gio256@protonmail.com>
idontgetoutmuch
pushed a commit
to idontgetoutmuch/mathlib4
that referenced
this pull request
Apr 7, 2025
…ommunity#20688) We provide macros for the following notations: - `⦋m⦌ₙ` denotes the `m`-dimensional simplex in the `n`-truncated simplex category. - `X _⦋m⦌ₙ` denotes the `m`-th term of an `n`-truncated simplicial object `X`. - `X ^⦋m⦌ₙ` denotes the `m`-th term of an `n`-truncated cosimplicial object `X`. For all of these notations, the truncation proof `p : m ≤ n` can also be provided using the syntax `⦋m, p⦌ₙ`, `X _⦋m, p⦌ₙ`, and `X ^⦋m, p⦌ₙ`, respectively. These notations generalize those already in use in `HomotopyCat.lean` and `Coskeletal.lean`. Delaborators for these notations are added in leanprover-community#20719. See leanprover-community#17732 and leanprover-community#20355 to understand the reason for the use of `subscriptTerm`. Co-authored-by: gio256 <gio256@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are not supported unless
enableInitializersExecutionis called, and various downstream scripts do not call this.https://leanprover.zulipchat.com/#narrow/channel/270676-lean4/topic/lean4checker.20failure/near/486191171 has some context for the underlying issue, which seems to be that Lean tries to finalize environment extensions even if initializers are disabled, leading to crashes if those extensions (such as the parser alias table) expect initializers to have run.
To prove this works, this removes
Lean.enableInitializersExecutionfrom the script to check the yaml files.This is what we will want to do anyway after leanprover/lean4#6325 lands, as this script should not need to run any extensions.