Skip to content

[Merged by Bors] - chore(Algebra): rename theorems for consistency#20271

Closed
artie2000 wants to merge 1 commit intomasterfrom
artie2000-rename-sq
Closed

[Merged by Bors] - chore(Algebra): rename theorems for consistency#20271
artie2000 wants to merge 1 commit intomasterfrom
artie2000-rename-sq

Conversation

@artie2000
Copy link
Copy Markdown
Collaborator

@artie2000 artie2000 commented Dec 27, 2024

Taking chore material out of #16094 to make the diff cleaner.

Moves:
isSquare_one -> IsSquare.one
isSquare_sq -> IsSquare.sq
even_two_nsmul -> Even.two_nsmul
isSumSq_sum_mul_self -> IsSumSq.mul_self

Open in Gitpod

@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Dec 27, 2024
@artie2000 artie2000 mentioned this pull request Dec 27, 2024
Closed
7 tasks
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 27, 2024

PR summary 68fd4b5701

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ IsSquare.one
+ IsSquare.sq
+ IsSumSq.sum_mul_self
+ even_two_nsmul

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@artie2000 artie2000 mentioned this pull request Dec 27, 2024
Closed
1 task
@artie2000 artie2000 added t-algebra Algebra (groups, rings, fields, etc) easy < 20s of review time. See the lifecycle page for guidelines. labels Dec 27, 2024
YaelDillies
YaelDillies approved these changes Dec 27, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 27, 2024

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Dec 27, 2024
bryangingechen
bryangingechen approved these changes Dec 28, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@bryangingechen bryangingechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors r+

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Dec 28, 2024
mathlib-bors bot pushed a commit that referenced this pull request Dec 28, 2024
@artie2000
chore(Algebra): rename theorems for consistency (#20271)
e8a3084 
Taking chore material out of #16094 to make the diff cleaner.

Moves:
isSquare_one -> IsSquare.one
isSquare_sq -> IsSquare.sq
even_two_nsmul -> Even.two_nsmul
isSumSq_sum_mul_self -> IsSumSq.mul_self
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Dec 28, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Algebra): rename theorems for consistency [Merged by Bors] - chore(Algebra): rename theorems for consistency Dec 28, 2024
@mathlib-bors mathlib-bors bot closed this Dec 28, 2024
@mathlib-bors mathlib-bors bot deleted the artie2000-rename-sq branch December 28, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bryangingechen bryangingechen bryangingechen approved these changes

@YaelDillies YaelDillies YaelDillies approved these changes

@jcommelin jcommelin Awaiting requested review from jcommelin

Assignees

No one assigned

Labels

easy < 20s of review time. See the lifecycle page for guidelines. maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@artie2000 @bryangingechen @YaelDillies