Skip to content

[Merged by Bors] - feat(Algebra): add missing substructure lemmas#20269

Closed
artie2000 wants to merge 3 commits intomasterfrom
artie2000-fill-missing-lemmas
Closed

[Merged by Bors] - feat(Algebra): add missing substructure lemmas#20269
artie2000 wants to merge 3 commits intomasterfrom
artie2000-fill-missing-lemmas

Conversation

@artie2000
Copy link
Copy Markdown
Collaborator

@artie2000 artie2000 commented Dec 27, 2024 •
edited
Loading

Add missing boilerplate lemmas about the maps .toNonUnitalSubsemiring and .subsemiringClosure

This PR is split off from #16094

Open in Gitpod

@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Dec 27, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 27, 2024 •
edited
Loading

PR summary 0559d53153

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Submonoid.subsemiringClosure_toNonUnitalSubsemiring
+ Subsemiring.coe_toNonUnitalSubsemiring
+ Subsemiring.mem_toNonUnitalSubsemiring
+ Subsemiring.toNonUnitalSubsemiring_inj
+ Subsemiring.toNonUnitalSubsemiring_injective
+ subsemiringClosure_mem

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Dec 27, 2024
@artie2000 artie2000 changed the title feat(Algebra/Algebra/Subalgebra/Unitisation): add missing toNonUnitalSubsemiring lemmas feat(Algebra): add missing substructure lemmas Dec 27, 2024
@artie2000 artie2000 mentioned this pull request Dec 27, 2024
Closed
7 tasks
YaelDillies
YaelDillies approved these changes Dec 27, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer delegate

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 27, 2024

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Dec 27, 2024
@artie2000 @YaelDillies
Update Mathlib/Algebra/Algebra/Subalgebra/Unitization.lean
0559d53 
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
jcommelin
jcommelin reviewed Jan 2, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Jan 2, 2025
mathlib-bors bot pushed a commit that referenced this pull request Jan 2, 2025
@artie2000
feat(Algebra): add missing substructure lemmas (#20269)
8b781ec 
Add missing boilerplate lemmas about the maps `.toNonUnitalSubsemiring ` and `.subsemiringClosure`

This PR is split off from #16094
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 2, 2025

Pull request successfully merged into master.

Build succeeded!

And happy new year! 🎉

@mathlib-bors mathlib-bors bot changed the title feat(Algebra): add missing substructure lemmas [Merged by Bors] - feat(Algebra): add missing substructure lemmas Jan 2, 2025
@mathlib-bors mathlib-bors bot closed this Jan 2, 2025
@mathlib-bors mathlib-bors bot deleted the artie2000-fill-missing-lemmas branch January 2, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcommelin jcommelin jcommelin left review comments

@YaelDillies YaelDillies YaelDillies approved these changes

Assignees

No one assigned

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@artie2000 @jcommelin @YaelDillies