[Merged by Bors] - feat(Algebra/Colimit/ModuleRing): generalize to Semiring/AddCommMonoid#20212
Closed
alreadydone wants to merge 3 commits intomasterfrom
Closed
[Merged by Bors] - feat(Algebra/Colimit/ModuleRing): generalize to Semiring/AddCommMonoid#20212alreadydone wants to merge 3 commits intomasterfrom
alreadydone wants to merge 3 commits intomasterfrom
Conversation
PR summary 9d6df56cd9
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Algebra.Colimit.ModuleRing | 1106 | 1104 | -2 (-0.18%) |
| Mathlib.LinearAlgebra.TensorProduct.DirectLimit | 1107 | 1105 | -2 (-0.18%) |
| Mathlib.Algebra.Category.ModuleCat.Limits | 1231 | 1229 | -2 (-0.16%) |
Import changes for all files
| Files | Import difference |
|---|---|
4 filesMathlib.Algebra.Category.ModuleCat.Limits Mathlib.Algebra.Category.AlgebraCat.Limits Mathlib.Algebra.Colimit.ModuleRing Mathlib.LinearAlgebra.TensorProduct.DirectLimit |
-2 |
Declarations diff
+ DirectLimit.Eqv
+ addCommMonoid
+ commGroup
+ exists_of₂
+ instance : AddCommMonoid (DirectLimit G f)
+ quotMk_of
+ quotientMk_of
+++--- congr
+++--- congr_apply_of
+++--- congr_symm_apply_of
+++--- lift_unique
+++--- map_comp
+++--- map_id
++- addCommGroup
+-+- DirectLimit
- directedSystem
- instance : AddCommGroup (DirectLimit G f)
-+-+ of.zero_exact
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
Decrease in tech debt: (relative, absolute) = (1.00, 0.00)
| Current number | Change | Type |
|---|---|---|
| 4840 | -1 | porting notes |
Current commit 9d6df56cd9
Reference commit 9acfd2fce9
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
c4034de to
cc6771a
Compare
4 tasks
cc6771a to
dfcb162
Compare
80cbf0f to
0b03333
Compare
ab35957 to
9d6df56
Compare
1 task
Member
|
Thanks 🎉 bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 26, 2024
#20212) and remove all unnecessary IsDirected assumptions.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and remove all unnecessary IsDirected assumptions.