Skip to content

[Merged by Bors] - feat(GroupWithZero): mul_(eq/ne)_zero_iff_(left/right)#20191

Closed
seewoo5 wants to merge 1 commit intomasterfrom
feature/mul_eq_zero_iff
Closed

[Merged by Bors] - feat(GroupWithZero): mul_(eq/ne)_zero_iff_(left/right)#20191
seewoo5 wants to merge 1 commit intomasterfrom
feature/mul_eq_zero_iff

Conversation

@seewoo5
Copy link
Copy Markdown
Collaborator

@seewoo5 seewoo5 commented Dec 23, 2024

Seperated from #18882. Add similar theorems, too.

Open in Gitpod

@seewoo5 seewoo5 added the t-algebra Algebra (groups, rings, fields, etc) label Dec 23, 2024
@seewoo5 seewoo5 self-assigned this Dec 23, 2024
@seewoo5 seewoo5 mentioned this pull request Dec 23, 2024
Closed
7 tasks
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 23, 2024

PR summary c6b0b2e965

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ mul_eq_zero_iff_left
+ mul_eq_zero_iff_right
+ mul_ne_zero_iff_left
+ mul_ne_zero_iff_right

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

YaelDillies
YaelDillies approved these changes Dec 23, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 23, 2024

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Dec 23, 2024
jcommelin
jcommelin reviewed Dec 23, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Dec 23, 2024
mathlib-bors bot pushed a commit that referenced this pull request Dec 23, 2024
@seewoo5
feat(GroupWithZero): mul_(eq/ne)_zero_iff_(left/right) (#20191)
26cd1c7
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Dec 23, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(GroupWithZero): mul_(eq/ne)_zero_iff_(left/right) [Merged by Bors] - feat(GroupWithZero): mul_(eq/ne)_zero_iff_(left/right) Dec 23, 2024
@mathlib-bors mathlib-bors bot closed this Dec 23, 2024
@mathlib-bors mathlib-bors bot deleted the feature/mul_eq_zero_iff branch December 23, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcommelin jcommelin jcommelin left review comments

@YaelDillies YaelDillies YaelDillies approved these changes

Assignees

@seewoo5 seewoo5

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@seewoo5 @jcommelin @YaelDillies