Skip to content

[Merged by Bors] - chore(ModelTheory): restate iInf to a more convenient statement#20166

Closed
ChrisHughes24 wants to merge 9 commits intomasterfrom
restateiInf
Closed

[Merged by Bors] - chore(ModelTheory): restate iInf to a more convenient statement#20166
ChrisHughes24 wants to merge 9 commits intomasterfrom
restateiInf

Conversation

@ChrisHughes24
Copy link
Copy Markdown
Member

@ChrisHughes24 ChrisHughes24 commented Dec 21, 2024 •
edited
Loading

I often found myself locally introducing Fintype.ofFinite. This statement means you don't have to do that.

Open in Gitpod

@ChrisHughes24 ChrisHughes24 added the t-logic Logic (model theory, etc) label Dec 21, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 21, 2024 •
edited
Loading

PR summary 1626128e37

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@ChrisHughes24 ChrisHughes24 changed the title Chore(ModelTheory): restate iInf to a more convenient statement chore(ModelTheory): restate iInf to a more convenient statement Dec 21, 2024
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Dec 21, 2024
@ChrisHughes24 ChrisHughes24 mentioned this pull request Dec 22, 2024
Closed
7 tasks
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Dec 22, 2024
This was referenced Dec 22, 2024
Closed
Closed
jcommelin
jcommelin reviewed Dec 23, 2024
View reviewed changes
@jcommelin jcommelin added the awaiting-author A reviewer has asked the author a question or requested changes. label Dec 23, 2024
ChrisHughes24 and others added 2 commits December 23, 2024 14:06
@ChrisHughes24 @jcommelin
Update Mathlib/ModelTheory/Semantics.lean
457fb11 
Co-authored-by: Johan Commelin <johan@commelin.net>
@ChrisHughes24
slight simplification
0edd0a9
jcommelin
jcommelin reviewed Dec 23, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Dec 23, 2024

✌️ ChrisHughes24 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed awaiting-author A reviewer has asked the author a question or requested changes. labels Dec 23, 2024
@ChrisHughes24 @jcommelin
Update Mathlib/FieldTheory/AxGrothendieck.lean
1626128 
Co-authored-by: Johan Commelin <johan@commelin.net>
@ChrisHughes24
Copy link
Copy Markdown
Member Author

ChrisHughes24 commented Dec 23, 2024

bors r+

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Dec 23, 2024
mathlib-bors bot pushed a commit that referenced this pull request Dec 23, 2024
@ChrisHughes24
chore(ModelTheory): restate iInf to a more convenient statement (#20166)
7d83d27 
Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Dec 23, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(ModelTheory): restate iInf to a more convenient statement [Merged by Bors] - chore(ModelTheory): restate iInf to a more convenient statement Dec 23, 2024
@mathlib-bors mathlib-bors bot closed this Dec 23, 2024
@mathlib-bors mathlib-bors bot deleted the restateiInf branch December 23, 2024 16:45
This was referenced Jun 25, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcommelin jcommelin jcommelin left review comments

Assignees

No one assigned

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors. t-logic Logic (model theory, etc)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ChrisHughes24 @jcommelin @mathlib4-dependent-issues-bot