[Merged by Bors] - refactor(ModelTheory): restate iAlls for a more convenient statement#20161
Closed
ChrisHughes24 wants to merge 5 commits intomasterfrom
Closed
[Merged by Bors] - refactor(ModelTheory): restate iAlls for a more convenient statement#20161ChrisHughes24 wants to merge 5 commits intomasterfrom
ChrisHughes24 wants to merge 5 commits intomasterfrom
Conversation
PR summary 8051169903Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
This was referenced Dec 21, 2024
jcommelin
reviewed
Dec 23, 2024
Mathlib/ModelTheory/Syntax.lean
Outdated
|
|
||
| /-- Given a map `f : α → β ⊕ γ`, `iAlls f φ` transforms a `L.Formula α` | ||
| into a `L.Formula β` by renaming variables with the map `f` and then universally | ||
| variable (β) |
Member
There was a problem hiding this comment.
Do you want to switch back to {} after iExs? Or was it your intention to keep ()?
Maybe variable in is more appropriate?
Member
Author
There was a problem hiding this comment.
That was a mistake. Well spotted. It's now fixed.
Contributor
|
This seems fine - it is simplifying current usage of |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 2, 2025
…20161) Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
Contributor
|
Pull request successfully merged into master. Build succeeded! And happy new year! 🎉 |
This was referenced Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of the time I used it
fwas just the identity function anyway. It's usually easier to just relabel the formula if it's the wrong type, because I usually know the typeβ, and given that I can see the expected type of my formula, and usually it's the same as the formula I'm giving it anyway, and if not I can relabel. Figuring out whatfshould be is kind of a headache without the help of seeing the expected type of everything.