[Merged by Bors] - feat: Define ENorm notation class#20121
Closed
fpvandoorn wants to merge 4 commits intomasterfrom
Closed
[Merged by Bors] - feat: Define ENorm notation class#20121fpvandoorn wants to merge 4 commits intomasterfrom
fpvandoorn wants to merge 4 commits intomasterfrom
Conversation
PR summary 02cceee8bcImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
| Current number | Change | Type |
|---|---|---|
| 88 | 1 | disabled deprecation lints |
| 63 | 1 | large files |
Current commit 02cceee8bc
Reference commit a38db992d0
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
1 task
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 20, 2024
* This PR only defines the notation class and two instances, but doesn't use it yet. * There is an existing unused definition of `ENorm`. Since I might use it in the future, I kept it around, but renamed it (and the file) `ENormedSpace`. I did not modify anything, and didn't add deprecations since it is unused and the main definition now has a different meaning.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 4, 2025
Extracted from #21375: these lemmas only change the assumption on the co-domain, but not any hypothesis. This continues the work started in #20121, #20122 and #21306: those PRs generalised the definitions resp. made lemma statements use the enorm. This PR starts generalising the lemmas using those definitions. This work is part of (and a necessary pre-requisite for) the Carleson project.
pfaffelh
pushed a commit
that referenced
this pull request
Feb 7, 2025
Extracted from #21375: these lemmas only change the assumption on the co-domain, but not any hypothesis. This continues the work started in #20121, #20122 and #21306: those PRs generalised the definitions resp. made lemma statements use the enorm. This PR starts generalising the lemmas using those definitions. This work is part of (and a necessary pre-requisite for) the Carleson project.
eric-wieser
reviewed
Apr 13, 2025
| noncomputable section | ||
|
|
||
| attribute [local instance] Classical.propDecidable | ||
| set_option linter.deprecated false |
Member
There was a problem hiding this comment.
@fpvandoorn, why did you add this? I've removed it again in #24001 and everything seems fine.
Member
Author
There was a problem hiding this comment.
Oh, probably because I was considering deprecating the whole file. Thanks for the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ENorm. Since I might use it in the future, I kept it around, but renamed it (and the file)ENormedSpace. I did not modify anything, and didn't add deprecations since it is unused and the main definition now has a different meaning.Zulip thread