[Merged by Bors] - chore(Algebra/Category/Ring): use unification hint to clean up proofs#20075
Closed
Vierkantor wants to merge 4 commits intomasterfrom
Closed
[Merged by Bors] - chore(Algebra/Category/Ring): use unification hint to clean up proofs#20075Vierkantor wants to merge 4 commits intomasterfrom
Vierkantor wants to merge 4 commits intomasterfrom
Conversation
PR summary 4b9241684aImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
kmill
reviewed
Dec 22, 2024
(Everything below is written for `CommRingCat`, but also holds for the other `RingCat`s.) As a consequence of #19757, it became harder to unify `(forget ?C).obj R =?= CommRingCat.carrier R` since `?C =?= CommRingCat` would no longer be inferred. This PR adds a unification hint that helps with all but 2 cases where we need to hint `C := CommRingCat`. The current unification hint uses `CommRingCat` as the argument to `forget`, even though we would like it to be an arbitrary category `C`, which can then trigger downstream unification of `C =?= CommRingCat`. However, it seems that dependent unification hints do not work: I cannot get Lean to typecheck `C =?= CommRingCat; (instC : Category C) =?= CommRingCat.instCategory |- ...`. I tried doing this for `ModuleCat` too and it did not seem to fix any required hints. Perhaps because `ModuleCat R` depends on the `R`?
169344e to
4b92416
Compare
Contributor
|
bors d+ |
Contributor
|
✌️ Vierkantor can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
Author
|
This still builds locally after merging master so: bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 13, 2025
…#20075) (Everything below is written for `CommRingCat`, but also holds for the other `RingCat`s.) As a consequence of #19757, it became harder to unify `(forget ?C).obj R =?= CommRingCat.carrier R` since `?C =?= CommRingCat` would no longer be inferred. This PR adds a unification hint that helps with all but 2 cases where we need to hint `C := CommRingCat`. The current unification hint uses `CommRingCat` as the argument to `forget`, even though we would like it to be an arbitrary category `C`, which can then trigger downstream unification of `C =?= CommRingCat`. However, it seems that dependent unification hints do not work: I cannot get Lean to typecheck `C =?= CommRingCat; (instC : Category C) =?= CommRingCat.instCategory |- ...`. I tried doing this for `ModuleCat` too and it did not seem to fix any required hints. Perhaps because `ModuleCat R` depends on the `R`?
Contributor
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Everything below is written for
CommRingCat, but also holds for the otherRingCats.)As a consequence of #19757, it became harder to unify
(forget ?C).obj R =?= CommRingCat.carrier Rsince?C =?= CommRingCatwould no longer be inferred. This PR adds a unification hint that helps with all but 2 cases where we need to hintC := CommRingCat.The current unification hint uses
CommRingCatas the argument toforget, even though we would like it to be an arbitrary categoryC, which can then trigger downstream unification ofC =?= CommRingCat. However, it seems that dependent unification hints do not work: I cannot get Lean to typecheckC =?= CommRingCat; (instC : Category C) =?= CommRingCat.instCategory |- ....I tried doing this for
ModuleCattoo and it did not seem to fix any required hints. Perhaps becauseModuleCat Rdepends on theR?