Skip to content

feat(SetTheory/ZFC/Ordinal): Lean ordinals to ZFC ordinals#19985

Closed
vihdzp wants to merge 52 commits intomasterfrom
vi.toPSet
Closed

feat(SetTheory/ZFC/Ordinal): Lean ordinals to ZFC ordinals#19985
vihdzp wants to merge 52 commits intomasterfrom
vi.toPSet

Conversation

@vihdzp
Copy link
Copy Markdown
Collaborator

@vihdzp vihdzp commented Dec 15, 2024

We define Ordinal.toZFSet and prove that its outputs are precisely the ZFC ordinals.


Open in Gitpod

@vihdzp vihdzp added the t-set-theory Set theory label Dec 15, 2024
@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Dec 15, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 15, 2024

PR summary 9b846cfdc2

Import changes exceeding 2%

% File
+37.04% Mathlib.SetTheory.ZFC.Ordinal

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.SetTheory.ZFC.Ordinal 486 666 +180 (+37.04%)
Mathlib.Order.SuccPred.CompleteLinearOrder 377 378 +1 (+0.27%)
Import changes for all files
Files Import difference
Mathlib.Order.SuccPred.CompleteLinearOrder 1
Mathlib.SetTheory.ZFC.Ordinal 180

Declarations diff

+ IsOrdinal.toZFSet_rank_eq
+ _root_.Ordinal.toZFSetIso
+ _root_.PSet.rank_mk
+ antisymm_iff
+ eq_of_subset_of_subset
+ iSup_succ
+ instance : HasSSubset PSet
+ instance : HasSSubset ZFSet
+ instance : PartialOrder ZFSet
+ instance : Preorder PSet
+ isOrdinal_iff_mem_range_toZFSet
+ isOrdinal_toZFSet
+ mem_def
+ mem_iff_rank_lt
+ mem_toPSet_iff
+ mem_toZFSet_iff
+ mk_toPSet
+ rank_inj
+ rank_toPSet
+ rank_toZFSet
+ subset_iff_rank_le
+ toPSet
+ toZFSet
+ toZFSet_mem_toZFSet_iff
+ toZFSet_subset_toZFSet_iff
+ toZFSet_toSet
+ type_toPSet
++ le_def
++ lt_def

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Increase in tech debt: (relative, absolute) = (2.00, 0.02)
Current number Change Type
89 2 disabled deprecation lints

Current commit 9b846cfdc2
Reference commit ffcd1a0e57

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Dec 15, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 7, 2025
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label May 9, 2025
@mathlib4-dependent-issues-bot
Copy link
Copy Markdown
Collaborator

@vihdzp
Copy link
Copy Markdown
Collaborator Author

vihdzp commented Jun 30, 2025

Moved to #26544.

@vihdzp vihdzp closed this Jun 30, 2025
@YaelDillies YaelDillies deleted the vi.toPSet branch August 15, 2025 16:55
mathlib-bors bot pushed a commit that referenced this pull request Nov 26, 2025
We define `Ordinal.toZFSet` and prove that its outputs are precisely the ZFC ordinals. Moved from #19985.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

large-import Automatically added label for PRs with a significant increase in transitive imports merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) t-set-theory Set theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants